[docker] Do not apply env values to pulsar_env.sh and bkenv.sh implicitly #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…citly when running apply-config-from-env.py.
Member
|
Thanks @fantapsody for the work. |
Member
|
/pulsarbot run-failure-checks |
Contributor
|
Seems fine to me. I would double check kubernetes files and helm charts to make sure this does not accidentally break something. |
sijie
approved these changes
Mar 23, 2020
Member
|
/pulsarbot run-failure-checks |
1 similar comment
Member
|
/pulsarbot run-failure-checks |
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 15, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…citly when running apply-config-from-env.py. (apache#6579)
lhotari
added a commit
to lhotari/datastax-pulsar-helm-chart
that referenced
this pull request
Mar 21, 2022
- this is obsolete after apache/pulsar#6579, apache/pulsar#4105 and apache/pulsar#5892 changes. apply-config-from-env.py doesn't properly handle replacements for shell scripts
lhotari
added a commit
to datastax/pulsar-helm-chart
that referenced
this pull request
Mar 21, 2022
…163) - this is obsolete after apache/pulsar#6579, apache/pulsar#4105 and apache/pulsar#5892 changes. apply-config-from-env.py doesn't properly handle replacements for shell scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The script
apply-config-from-env.pyalways applies env config to env scripts. However, with the changes from #4105 and #5892, it seems there is no need to do so anymore. On the other hand, it will interfere with the bash variable replacement mechanisms by replacing the values in scripts directly.Modifications
Remove
['conf/pulsar_env.sh', 'conf/bkenv.sh']fromconf_files.