[fix][proxy] Fix client service url#16834
Merged
Technoboy- merged 1 commit intoapache:masterfrom Jul 29, 2022
Merged
Conversation
Member
Author
|
/pulsarbot rerun-failure-checks |
|
@nodece Please provide a correct documentation label for your PR. |
Technoboy-
approved these changes
Jul 29, 2022
|
@nodece Please provide a correct documentation label for your PR. |
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
@nodece Please add unit test to avoid any changes to break here.
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
fix-client-service-url-on-proxy
branch
from
829c744 to
77c2a1c
Compare
Contributor
Added after your comment, so merged. |
Member
Author
Thanks! Done.
Thank @Technoboy- for merging this PR! |
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit eedee40)
Jason918
pushed a commit
that referenced
this pull request
Jul 29, 2022
(cherry picked from commit eedee40)
|
@nodece Please provide a correct documentation label for your PR. |
Jason918
pushed a commit
to Jason918/pulsar
that referenced
this pull request
Jul 30, 2022
This reverts commit 10b4e99.
2 tasks
Jason918
added a commit
that referenced
this pull request
Jul 31, 2022
* Revert "[fix][proxy] Fix client service url (#16834)" This reverts commit 10b4e99. * Revert "[Build] Use grpc-bom to align grpc library versions (#15234)" This reverts commit 99c93d2. * Revert "upgrade aircompressor to 0.20 (#11790)" This reverts commit 5ad16b6. * Revert "[Branch-2.7] Fixed deadlock on metadata cache missing while doing checkReplication (#12484)" This reverts commit 32fe228. * Revert changes of PersistentTopic#getMessageTTL in #12339. Co-authored-by: JiangHaiting <janghaiting@apache.org>
Jason918
pushed a commit
to Jason918/pulsar
that referenced
this pull request
Aug 1, 2022
(cherry picked from commit eedee40)
1 task
Member
Author
|
Move |
Jason918
added a commit
that referenced
this pull request
Aug 1, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Aug 1, 2022
(cherry picked from commit eedee40)
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Aug 8, 2022
(cherry picked from commit eedee40)
mattisonchao
pushed a commit
that referenced
this pull request
Aug 10, 2022
(cherry picked from commit eedee40)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com
Motivation
When the TLS is enabled, the client always uses the non-TLS URL.
Modifications
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)