Skip to content

Conversation

@hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Aug 10, 2022

Motivation

default value of logSizeLimit is 1G since bookkeeper-4.4.0
apache/bookkeeper@10cab08

pulsar-2.x use bookkeeper-4.7.0 or above.
https://github.com/apache/pulsar/blob/v2.0.1-incubating/pom.xml#L120

Modifications

  • Change default value of logSizeLimit(1073741824->2147483648)

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@hrsakai hrsakai added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 10, 2022
@hrsakai hrsakai added this to the 2.11.0 milestone Aug 10, 2022
@hrsakai hrsakai self-assigned this Aug 10, 2022
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codelipenghui codelipenghui merged commit ba44883 into apache:master Aug 11, 2022
coderzc pushed a commit to coderzc/pulsar that referenced this pull request Aug 13, 2022
Technoboy- pushed a commit to merlimat/pulsar that referenced this pull request Aug 16, 2022
momo-jun added a commit to momo-jun/pulsar that referenced this pull request Aug 17, 2022
momo-jun added a commit that referenced this pull request Sep 7, 2022
* Sync recent changes from #17030, #17039, #16315, and #17057

* fix #17119

* minor updates

* add link of release notes to navigation

* fix

* update release process as per PIP-190

* minor fix

* minor fix

* Update release-process.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants