Skip to content

Conversation

@momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Aug 17, 2022

Modifications

image

Documentation

  • doc

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 17, 2022
@momo-jun momo-jun marked this pull request as ready for review August 17, 2022 08:56
@momo-jun momo-jun self-assigned this Sep 5, 2022
@momo-jun momo-jun mentioned this pull request Sep 5, 2022
4 tasks
@Anonymitaet Anonymitaet added this to the 2.12.0 milestone Sep 6, 2022
@momo-jun momo-jun merged commit 284001a into apache:master Sep 7, 2022
> - The minor release doc is generated based on the previous minor release (e.g.: `2.X.2` doc is generated based on `2.X.1`, and `2.X.3`doc is generated based on `2.X.2`), so you cannot use the `yarn run version <release-version>` command directly.
> Starting from 2.8, you don't need to generate an independent doc set or update the Pulsar site for bug-fix releases, such as 2.8.1, 2.8.2, and so on. Instead, the generic doc set 2.8.x is used.

:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@momo-jun can you fix this layout issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the finding. I will fix it in a follow-up PR.

@momo-jun momo-jun modified the milestones: 2.12.0, 2.11.0 Sep 13, 2022
Comment on lines -478 to +477
### Update the site for major releases
For major release, the website is updated based on the `master` branch.
### Update the site for minor releases
For minor releases, such as 2.10, the website is updated based on the `master` branch.
Copy link
Contributor

@BewareMyPower BewareMyPower Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momo-jun Why did you make this change? I think only major releases (like 2.10.0) are updated based on the master branch.

ping @mattisonchao @Technoboy- @codelipenghui @gaoran10 @Jason918

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to make sure I didn't understand wrong.

  • major release: 2.X.0 (checkout from master)
  • minor release: 2.X.Y (checkout from branch-2.X)

Copy link
Contributor Author

@momo-jun momo-jun Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BewareMyPower This change is part of PIP-190.

You are right that 2.10 is updated based on the master branch. Quite often we regard it as a major version in daily talk. But it should be a minor version, while 3.0 is the next major version.
Pulsar version number is comprised of 3 components: major.minor.bug-fix according to the definition in PIP-47.

Copy link
Contributor Author

@momo-jun momo-jun Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As clarified by @codelipenghui and @BewareMyPower, the current consensus in the Pulsar community is:

  • feature release (major release): 2.10.0, 2.11.0...
  • bug-fix release (minor release): 2.10.1, 2.10.2...

I will update the wording accordingly in #17684.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] add explanations of "topics can be compacted on topic level automatically"

4 participants