Skip to content

Conversation

@Jason918
Copy link
Contributor

@Jason918 Jason918 commented Sep 3, 2022

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@Jason918 Jason918 self-assigned this Sep 3, 2022
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 3, 2022
@Jason918 Jason918 requested a review from Anonymitaet September 3, 2022 13:47
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momo-jun we do not need to generate doc sets for minor versions, right?
Seems that developers are following rules here, could you please update? Thank you!

@momo-jun
Copy link
Contributor

momo-jun commented Sep 5, 2022

@Anonymitaet starting from 2.8.x, we don't need to do so, but for 2.7.5, I think the doc set needs to be generated because we don't have one for 2.7.x.
I've included the changes to the release process in #17130.

@@ -1,5 +1,6 @@
[
"2.10.1",
"2.7.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should this change be made to line 13 (below 2.8.0) instead of here?
  2. Should release.json and version.json be updated after 2.7.5 is released?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! The site2/website/versions.json file needs an update as well. @Jason918

Copy link
Contributor Author

@Jason918 Jason918 Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should this change be made to line 13 (below 2.8.0) instead of here?

Addressed. PTAL @Anonymitaet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! The site2/website/versions.json file needs an update as well. @Jason918

Addressed. PTAL. @momo-jun

@Anonymitaet Anonymitaet added this to the 2.12.0 milestone Sep 6, 2022
@Anonymitaet
Copy link
Member

@Jason918 may I know when 2.7.5 will be released and announced?

@Jason918
Copy link
Contributor Author

Jason918 commented Sep 6, 2022

@Jason918 may I know when 2.7.5 will be released and announced?

@Anonymitaet Right after the doc is ready. All the released artifacts are ready.

@Jason918 Jason918 merged commit bf264c8 into apache:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants