[improve][cli] Pulsar shell, Pulsar admin, Pulsar client and Pulsar perf: support for Windows #17243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Aug 24, 2022
pulsar-client-tools/src/main/java/org/apache/pulsar/shell/PulsarShell.java
Show resolved
Hide resolved
nicoloboschi
changed the title
Contributor
|
@eolivelli license check is failing |
1 task
nicoloboschi
changed the title
nicoloboschi
force-pushed
the
pulsar-shell-windows
branch
4 times, most recently
from
7c6929a to
c77668a
Compare
tisonkun
reviewed
Aug 29, 2022
tisonkun
reviewed
Aug 29, 2022
tisonkun
approved these changes
Aug 29, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
I don't have a Windows environment to verify these scripts, though.
nicoloboschi
force-pushed
the
pulsar-shell-windows
branch
from
59d6b5b to
7fb69fa
Compare
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Aug 30, 2022
…erf: support for Windows (apache#17243)
Technoboy-
pushed a commit
that referenced
this pull request
Nov 15, 2022
…erf: support for Windows (#17243)
| set "OPTS=%OPTS% -Dpulsar.routing.appender.default=%PULSAR_ROUTING_APPENDER_DEFAULT%" | ||
|
|
||
| :error | ||
| exit /b 1 |
Contributor
There was a problem hiding this comment.
Why did you add this line? I cannot use pulsar-shell on Windows unless I removed this line.
Contributor
Author
There was a problem hiding this comment.
it's a leftover, we can drop it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16688
TL; DR - now Pulsar shell works on Windows
Motivation
Currently pulsar shell is only runnable on Unix system because the entry point script is written in bash.
Modifications
pulsar-shell.cmd,pulsar-admin.cmd,pulsar-client.cmdandpulsar-perf.cmdfiles (written in Windows Command Prompt language) that starts their processesIt implements the exact same configurations from the current pulsar-shell, even the java8 detection. The only thing not implemented is the on-the-fly compile. Actually, the batch script only work if you unzip the distro tarball. Running it from the codebase (so without the
libdir) is not supported (and it's okay since currently it's not even possible develop Pulsar on a Win machine)Added the jna lib to make the jline command prompt display colors correctly - will need to upgrade to the latest JNA version to fix some current issues
Added zip distribution to pulsar-shell (distribution/shell). The idea is to distribute both and suggest to download the .zip for Windows user
doc-not-needed