[improve][dependency] Upgrade JNA to 5.12.1 #17262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
force-pushed
the
upgrade-jna
branch
from
b57e0f9 to
ce34a8d
Compare
Contributor
Author
|
OWASP check failure due to #17282 |
eolivelli
approved these changes
Aug 25, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I am aware of users that already upgraded JNA for BookKeeper in production without problems. I don't expect problems with this major upgrade
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
Aug 30, 2022
(cherry picked from commit c55dda1)
zymap
pushed a commit
to zymap/pulsar
that referenced
this pull request
Sep 5, 2022
--- *Motivation* We update the jna version in this [PR](apache#17262). We should update the version in presto license file as well.
5 tasks
zymap
added a commit
that referenced
this pull request
Sep 6, 2022
) --- *Motivation* We update the jna version in this [PR](#17262). We should update the version in presto license file as well.
lhotari
pushed a commit
to apache/pulsar-sql
that referenced
this pull request
Oct 18, 2024
…459) --- *Motivation* We update the jna version in this [PR](apache/pulsar#17262). We should update the version in presto license file as well.
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Apr 30, 2025
(cherry picked from commit c55dda1) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
May 20, 2025
(cherry picked from commit c55dda1) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 23, 2025
(cherry picked from commit c55dda1) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
JLine3 doesn't work well with current JNA version on Windows. It's a requirement for #17243
Modifications
Note that this lib is also used by the ZK cli. I tested it and it still works correctly after the upgrade.
doc-not-needed