-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][ci] CI: fix required jobs check #17926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/pulsarbot rerun-failure-checks |
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @nicoloboschi !
|
https://github.com/apache/pulsar/actions/runs/3181864030/jobs/5189239809#step:12:28097 I wonder this is related to #17862 |
|
I'm working on a fix for the " stdout: Incorrect proxyProtocol name , stderr: java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.client.api.ProxyProtocol." issue. |
#17930 fixes this issue. @nicoloboschi @tisonkun please review |
|
picking up #17930 changes by closing and re-opening |
Motivation
After #17881 the "CI checks completed" job only verify the system-tests, bypassing all the other tests. Diff https://github.com/apache/pulsar/pull/17881/files#diff-069360707fedfc682947effc8f7fac874fa378ec5c70abec25f88939c87379d3R959
I noticed it in #17915

Modifications
Also closes #17923
doc-not-needed