-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][pulsar-testclient] Add proxyServiceUrl and proxyProtocol as options for PerfTool CLI #17862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| tlsTrustCertsFilePath=./path | ||
| tlsAllowInsecureConnection=true | ||
| tlsEnableHostnameVerification=true | ||
| proxyServiceURL=https://my-proxy-pulsar:4443/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might fail any existing tests which are using this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is used by only one testcase "testReadFromConfigFile" which I have modified to work.
|
@rdhabalia @vineeth1995 one test fails like this:
this is the run |
|
Motivation
The pulsar-perf-tool should be able to take "proxyServiceUrl" and "proxyProtocol" as an input arguments as it can be provided by the user.
Modifications
Add "proxyServiceUrl" and "proxyProtocol" into PerformanceBaseArguments.java class.
Make changes into PerfClientUtils.java to pass "proxyServiceUrl" and "proxyProtocol" to clientBuilder.
Add unit test cases to verify
Verifying this change
This change added tests and can be verified as follows:
-Added unit test to verify functionality
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
ready-to-test