Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Oct 4, 2022

Motivation

#17862 added support for pulsar-perf CLI tools (with #17930 to fix some gaps).
It would be consistent to add support for specifying proxyServiceUrl & proxyProtocol in the configuration file also for pulsar-client CLI tool.

Modifications

Add proxyServiceUrl / proxyProtocol parsing from conf file to pulsar-client CLI.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#95

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@lhotari lhotari force-pushed the lh-add-proxyServiceUrl-proxyProtocol-parsing-from-properties branch from ff71d89 to d9885c2 Compare November 4, 2022 19:07
@lhotari
Copy link
Member Author

lhotari commented Nov 4, 2022

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #17932 (d9885c2) into master (67d9d63) will increase coverage by 6.81%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17932      +/-   ##
============================================
+ Coverage     40.29%   47.10%   +6.81%     
- Complexity     8685    10331    +1646     
============================================
  Files           687      687              
  Lines         67441    67437       -4     
  Branches       7225     7226       +1     
============================================
+ Hits          27175    31768    +4593     
+ Misses        37257    32090    -5167     
- Partials       3009     3579     +570     
Flag Coverage Δ
unittests 47.10% <0.00%> (+6.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 36.87% <0.00%> (-0.03%) ⬇️
...rg/apache/bookkeeper/mledger/impl/OpReadEntry.java 65.55% <ø> (+0.72%) ⬆️
.../transaction/TransactionCoordinatorClientImpl.java 0.00% <0.00%> (ø)
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
.../apache/pulsar/broker/loadbalance/LoadManager.java 61.11% <0.00%> (-16.67%) ⬇️
.../apache/pulsar/broker/admin/impl/PackagesBase.java 54.12% <0.00%> (-13.77%) ⬇️
...pulsar/broker/service/PulsarCommandSenderImpl.java 67.53% <0.00%> (-10.48%) ⬇️
...oker/service/schema/SchemaRegistryServiceImpl.java 56.75% <0.00%> (-8.11%) ⬇️
...tent/PersistentDispatcherSingleActiveConsumer.java 55.79% <0.00%> (-3.45%) ⬇️
...ookkeeper/mledger/impl/ManagedCursorContainer.java 76.03% <0.00%> (-3.31%) ⬇️
... and 196 more

@github-actions github-actions bot removed the Stale label Nov 5, 2022
@lhotari lhotari merged commit a2c1534 into apache:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants