Skip to content

[improve][test] Improve AdminApiTest to reduce the execution time #17980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 2 commits into from
Oct 13, 2022
Merged

[improve][test] Improve AdminApiTest to reduce the execution time #17980

codelipenghui merged 2 commits into from
Oct 13, 2022

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Oct 10, 2022 •
edited
Loading

Fixes:

Modifications

Only execution once setup/clean and clean tenants/namespaces/producer/consumer after the end of each test execution.

Execution time after improve test:

Tests run: 83, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 404.325 s - in org.apache.pulsar.broker.admin.AdminApiTest

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: coderzc#10

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 10, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 10, 2022
@codelipenghui codelipenghui reopened this Oct 10, 2022
@codelipenghui
Copy link
Contributor

codelipenghui commented Oct 11, 2022 •
edited
Loading

@coderzc Please help check the failed test of Broker Group 3, it looks like related to this change

@coderzc coderzc changed the title [improve][test] Improve AdminApi2Test to reduce the execution time [improve][test] Improve AdminApiTest to reduce the execution time Oct 11, 2022
@coderzc
Copy link
Member Author

coderzc commented Oct 11, 2022 •
edited
Loading

@coderzc Please help check the failed test of Broker Group 3, it looks like related to this change

AdminApi2Test have two timeout test, this pr change is AdminApiTest, I try again once.

@coderzc
Copy link
Member Author

coderzc commented Oct 11, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit e4d3c49 into apache:master Oct 13, 2022
liangyepianzhou pushed a commit that referenced this pull request Feb 25, 2023
@coderzc @liangyepianzhou
[improve][test] Improve AdminApiTest to reduce the execution time (#1…
de786f6 
…7980)

(cherry picked from commit e4d3c49)
@liangyepianzhou liangyepianzhou mentioned this pull request Feb 25, 2023
Merged
15 tasks
liangyepianzhou added a commit that referenced this pull request Feb 26, 2023
@liangyepianzhou
Revert "[improve][test] Improve AdminApiTest to reduce the execution …
57e81b2 
…time (#17980)"

This reverts commit de786f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

Assignees

@coderzc coderzc

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@coderzc @codelipenghui @poorbarcode