Skip to content

Conversation

@liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Feb 25, 2023

Motivation

Just run and fix tests

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

@liangyepianzhou Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Feb 25, 2023
@liangyepianzhou liangyepianzhou changed the title [branch-2.10][test]Improve adminAPITest and optimize some test method [branch-2.10][test]Run and fix tests Feb 26, 2023
@liangyepianzhou liangyepianzhou merged commit 0eaa671 into branch-2.10 Feb 26, 2023
@liangyepianzhou liangyepianzhou deleted the xaingying/cherry-pick-2.10/improve_test branch February 27, 2023 10:49
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Feb 28, 2023
Co-authored-by: Cong Zhao <zhaocong@apache.org>
Co-authored-by: fengyubiao <9947090@qq.com>
Co-authored-by: AloysZhang <lofterzhang@gmail.com>
(cherry picked from commit 0eaa671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants