Skip to content

[fix][broker][branch-2.11] fix delete_when_subscriptions_caught_up doesn't work while have active consumers #18320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 2 commits into from
Nov 5, 2022
Merged

[fix][broker][branch-2.11] fix delete_when_subscriptions_caught_up doesn't work while have active consumers #18320

Technoboy- merged 2 commits into from
Nov 5, 2022

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Nov 3, 2022

Motivation

The current behavior for the delete_when_subscriptions_caught_up strategy is not expected. The active consumer will not be closed even if users enable delete_when_subscriptions_caught_up and there are no backlogs for the topic.

It should be the part that #6077 has missed. And Sijie has mentioned in the comment #6077 (review).

To correct the behavior of delete_when_subscriptions_caught_up

Modifications

Close active consumers if delete_when_subscriptions_caught_up is applied and there are no backlogs for the topic. So that the topic can be cleaned up properly by the topic GC thread.

Verifying this change

Updated the existing test.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codelipenghui codelipenghui self-assigned this Nov 3, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 3, 2022
@codelipenghui
Copy link
Contributor Author

codelipenghui commented Nov 4, 2022

/pulsarbot run-failure-checks

@Technoboy- Technoboy- force-pushed the penghui/cherry-pick-18283 branch from 9d88bd0 to a3115bd Compare November 4, 2022 14:35
@Technoboy- Technoboy- merged commit 8de67dc into apache:branch-2.11 Nov 5, 2022
@codelipenghui codelipenghui deleted the penghui/cherry-pick-18283 branch November 5, 2022 01:07
@codelipenghui codelipenghui mentioned this pull request Nov 16, 2022
Merged
13 tasks
codelipenghui added a commit that referenced this pull request Nov 16, 2022
@codelipenghui
[fix][broker] fix delete_when_subscriptions_caught_up doesn't work wh…
f5c9354 
…ile have active consumers (#18320)

(cherry picked from commit 8de67dc)
codelipenghui added a commit that referenced this pull request Nov 16, 2022
@codelipenghui
[fix][broker] fix delete_when_subscriptions_caught_up doesn't work wh…
3cf167a 
…ile have active consumers (#18320)

(cherry picked from commit 8de67dc)
(cherry picked from commit f5c9354)
@mattisonchao mattisonchao mentioned this pull request Nov 21, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@codelipenghui codelipenghui

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test release/2.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codelipenghui @Technoboy-