[improve][client] Optimize code for MultiTopicsConsumerImpl

[Pomelongan]

Motivation

In org.apache.pulsar.client.impl.MultiTopicsConsumerImpl#createPartitionedConsumer, it is more appropriate to change some places to generic format. For example, see line 932, it is better to changeConsumerConfigurationData to ConsumerConfigurationData<T>.

pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java

Lines 932 to 940 in fc655c8

	ConsumerConfigurationData cloneConf = conf.clone();
	String topicName = cloneConf.getSingleTopic();
	cloneConf.getTopicNames().remove(topicName);
	CompletableFuture<Consumer> future = new CompletableFuture<>();
	MultiTopicsConsumerImpl consumer = new MultiTopicsConsumerImpl(client, topicName, cloneConf, executorProvider,
	future, schema, interceptors, true /* createTopicIfDoesNotExist */);
	future.thenCompose(c -> ((MultiTopicsConsumerImpl) c).subscribeAsync(topicName, numPartitions))

Modifications

Change some code in org.apache.pulsar.client.impl.MultiTopicsConsumerImpl#createPartitionedConsumer to generic mode.

Verifying this change

• Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The binary protocol
• The REST endpoints
• The admin CLI options
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: Pomelongan#16

[github-actions]

@Pomelongan Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[codelipenghui]

@Pomelongan Please merge/rebase the master branch. There is a flaky test that has been fixed. #18751

[codecov-commenter]

Codecov Report

Merging #18748 (31c8b87) into master (68ca60c) will decrease coverage by 2.26%.
The diff coverage is 11.11%.

@@             Coverage Diff              @@
##             master   #18748      +/-   ##
============================================
- Coverage     50.05%   47.78%   -2.27%     
+ Complexity    11024    10657     -367     
============================================
  Files           703      703              
  Lines         68814    68816       +2     
  Branches       7378     7377       -1     
============================================
- Hits          34446    32886    -1560     
- Misses        30621    32208    +1587     
+ Partials       3747     3722      -25     

Flag	Coverage Δ
unittests	47.78% <11.11%> (-2.27%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...r/stats/prometheus/PrometheusMetricsGenerator.java	0.00% <0.00%> (-67.40%)	⬇️
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java	22.86% <0.00%> (ø)
...ersistentStickyKeyDispatcherMultipleConsumers.java	59.31% <25.00%> (-3.07%)	⬇️
...n/java/org/apache/pulsar/broker/admin/v3/Sink.java	0.00% <0.00%> (-100.00%)	⬇️
...java/org/apache/pulsar/broker/admin/v3/Source.java	0.00% <0.00%> (-100.00%)	⬇️
...a/org/apache/pulsar/broker/admin/v3/Functions.java	0.00% <0.00%> (-100.00%)	⬇️
...ar/broker/stats/prometheus/ManagedLedgerStats.java	0.00% <0.00%> (-100.00%)	⬇️
...oker/stats/prometheus/PrometheusMetricStreams.java	0.00% <0.00%> (-100.00%)	⬇️
.../stats/prometheus/AggregatedSubscriptionStats.java	0.00% <0.00%> (-100.00%)	⬇️
...metheus/AggregatedTransactionCoordinatorStats.java	0.00% <0.00%> (-100.00%)	⬇️
... and 103 more