Skip to content

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Dec 6, 2022

Fixes: #18732

Motivation

Revert #18467 to fix the JVM crash issue, which has been described in #18732
After the CI gets passed. I will create a GitHub issue for the caffeine repo

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codelipenghui codelipenghui added ready-to-test dependencies Pull requests that update a dependency file labels Dec 6, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Dec 6, 2022
@codelipenghui codelipenghui self-assigned this Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

@codelipenghui Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Dec 6, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #18751 (2c3aa07) into master (99e26f5) will increase coverage by 2.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18751      +/-   ##
============================================
+ Coverage     44.79%   47.14%   +2.34%     
+ Complexity    10026     9331     -695     
============================================
  Files           703      623      -80     
  Lines         68808    59072    -9736     
  Branches       7375     6142    -1233     
============================================
- Hits          30822    27849    -2973     
+ Misses        34378    28195    -6183     
+ Partials       3608     3028     -580     
Flag Coverage Δ
unittests 47.14% <ø> (+2.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sar/broker/service/schema/SchemaRegistryStats.java 71.25% <0.00%> (-1.25%) ⬇️
...rg/apache/pulsar/client/impl/PulsarClientImpl.java 43.85% <0.00%> (-0.95%) ⬇️
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 22.86% <0.00%> (-0.12%) ⬇️
...ava/org/apache/bookkeeper/mledger/ScanOutcome.java
...okkeeper/mledger/impl/ManagedCursorMXBeanImpl.java
...okkeeper/mledger/impl/ShadowManagedLedgerImpl.java
...ger/offload/jcloud/impl/OffloadIndexBlockImpl.java
...d/jcloud/impl/BlobStoreBackedReadHandleImplV2.java
...eper/mledger/offload/jcloud/OffloadIndexBlock.java
...ger/offload/jcloud/OffloadIndexBlockV2Builder.java
... and 142 more

@codelipenghui codelipenghui changed the title Revert "[improve][misc] Update caffeine from 2.9.1 to 3.1.2 (#18647)" [fix][test] Revert "[improve][misc] Update caffeine from 2.9.1 to 3.1.2 (#18647)" Dec 6, 2022
@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Dec 6, 2022
@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-not-needed Your PR changes do not impact docs doc-label-missing labels Dec 6, 2022
@codelipenghui codelipenghui merged commit b36e012 into apache:master Dec 6, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@codelipenghui codelipenghui deleted the penghui/fix-unit-other branch March 26, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is this a flaky-test? bookkeeper.LedgerManagerIteratorTest

6 participants