[cleanup][broker] Cleanup ManagedLedgerImpl's nouse method: isLedgersReadonly#19513
[cleanup][broker] Cleanup ManagedLedgerImpl's nouse method: isLedgersReadonly#19513AnonHxy merged 1 commit intoapache:masterfrom
Conversation
|
/pulsarbot run-failure-checks |
|
@StevenLuMT - what is the justification for removing this method? We added it as part of PIP 180. I think we should consult with @Jason918 before we do this kind of cleanup up, as this feature was only just added in November with #18265 and might not be something we should remove. |
@michaeljmarshall Thank you for the reminding. It's OK to delete this. I add this method during locally updates. It's not used any more. |
@michaeljmarshall I have communicated with @Jason918 , it's not use any more, |
|
Great! Thanks for verifying. |
Motivation
Cleanup ManagedLedgerImpl's nouse method: isLedgersReadonly
Modifications
Cleanup ManagedLedgerImpl.isLedgersReadonly.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
Check the box below or label this PR directly.
Need to update docs?
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: StevenLuMT#5