Skip to content

[cleanup][broker] Cleanup ManagedLedgerImpl's nouse method: isLedgersReadonly #19513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnonHxy merged 1 commit into from
Feb 16, 2023
Merged

[cleanup][broker] Cleanup ManagedLedgerImpl's nouse method: isLedgersReadonly #19513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,6 @@ public void operationFailed(MetaStoreException e) {
scheduleTimeoutTask();
}

protected boolean isLedgersReadonly() {
return false;
}

protected synchronized void initializeBookKeeper(final ManagedLedgerInitializeLedgerCallback callback) {
if (log.isDebugEnabled()) {
log.debug("[{}] initializing bookkeeper; ledgers {}", name, ledgers);
Expand Down
5 changes: 0 additions & 5 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ShadowManagedLedgerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,6 @@ public void operationFailed(ManagedLedgerException.MetaStoreException e) {
});
}

@Override
protected boolean isLedgersReadonly() {
return true;
}

@Override
protected synchronized void initializeBookKeeper(ManagedLedgerInitializeLedgerCallback callback) {
if (log.isDebugEnabled()) {
Expand Down