[improve][client] Disable polling pattern topics when TopicListWatcher is enabled. #20779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
release/3.0.2
and removed
doc-not-needed
Technoboy-
force-pushed
the
disable-polling-topic
branch
from
39021b5 to
b7b350d
Compare
Codecov Report
@@ Coverage Diff @@
## master #20779 +/- ##
=============================================
+ Coverage 33.44% 73.09% +39.65%
- Complexity 12097 32144 +20047
=============================================
Files 1612 1867 +255
Lines 126568 139056 +12488
Branches 13824 15300 +1476
=============================================
+ Hits 42328 101649 +59321
+ Misses 78686 29352 -49334
- Partials 5554 8055 +2501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codelipenghui
approved these changes
Jul 17, 2023
mattisonchao
approved these changes
Jul 17, 2023
Technoboy-
added a commit
that referenced
this pull request
Aug 17, 2023
This was referenced Jan 4, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Disable polling pattern topics task when TopicListWatcher is enabled.
The current tests have covered the cases.
Documentation
docdoc-requireddoc-not-neededdoc-complete