[fix][broker] Pattern subscription doesn't work when the pattern excludes the topic domain.

[shibd]

Motivation

After #16062, we use a notification machine to discover topic changes for pattern subscriptions.

If the user sets a pattern string like my-property/my-ns/test-pattern.*(without topic domain) when creating a subscription.

It doesn't receive updates for the latest topics because the topic names include the domain when matching.

For example:

• topicName: persistent://my-property/my-ns/test-pattern-1
• topicsPattern: my-property/my-ns/test-pattern.*

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java

Line 73 in fad925f

if (topicsPattern.matcher(TopicName.get(topicName).getPartitionedTopicName()).matches()) {

You can run test to reproduce it: testSubscribePatterWithOutTopicDomain

BTW: This issue has always existed, but some clients had a fallback by periodically querying topics for updates.
For the Java client, this has been removed after #20779, which is why the issue occurs.

Modifications

• Remove the domain from both the topic name and the topic pattern for matching.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (bbc6224) to head (2eda62b).
Report is 960 commits behind head on master.

Files with missing lines	Patch %	Lines
...va/org/apache/pulsar/broker/service/ServerCnx.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #24072      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.66%     
+ Complexity    32624    32428     -196     
============================================
  Files          1877     1863      -14     
  Lines        139502   144291    +4789     
  Branches      15299    16459    +1160     
============================================
+ Hits         102638   107115    +4477     
+ Misses        28908    28719     -189     
- Partials       7956     8457     +501     

Flag	Coverage Δ
inttests	26.68% <0.00%> (+2.10%)	⬆️
systests	23.16% <25.00%> (-1.16%)	⬇️
unittests	73.75% <75.00%> (+0.90%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...apache/pulsar/broker/service/TopicListService.java	67.46% <100.00%> (+0.26%)	⬆️
...ava/org/apache/pulsar/common/topics/TopicList.java	100.00% <ø> (+10.34%)	⬆️
...va/org/apache/pulsar/broker/service/ServerCnx.java	72.94% <50.00%> (+0.80%)	⬆️

... and 1060 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lhotari]

Please also update the javadoc which is now outdated:

pulsar/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java

Lines 145 to 146 in f199e88

	* <p>It accepts a regular expression that is compiled into a pattern internally. E.g.,
	* "persistent://public/default/pattern-topic-.*"

.
I guess it could be explained that the persistent:// / non-persistent:// prefix is ignored when evaluating the pattern.

[lhotari]

LGTM

[lhotari]

Good work @shibd