Skip to content

Conversation

@AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Sep 4, 2023

Motivation

See pip: #21129

Modifications

Add BundleDataResources

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: AnonHxy#45

@AnonHxy AnonHxy closed this Sep 5, 2023
@AnonHxy AnonHxy reopened this Sep 5, 2023
@AnonHxy AnonHxy self-assigned this Sep 5, 2023
@AnonHxy AnonHxy changed the title [refactor][broker] Add BundleDataResources [refactor][broker] PIP-301 Part-1: Add BundleDataResources Sep 5, 2023
@AnonHxy AnonHxy force-pushed the refactor_bundle_resources branch from ea3595b to 0fda81b Compare September 25, 2023 15:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.23%. Comparing base (5c9b72a) to head (0fda81b).
⚠️ Report is 1645 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pulsar/broker/resources/PulsarResources.java 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21119       +/-   ##
=============================================
+ Coverage     24.85%   73.23%   +48.37%     
- Complexity      197    32393    +32196     
=============================================
  Files          1696     1888      +192     
  Lines        130448   140170     +9722     
  Branches      14252    15428     +1176     
=============================================
+ Hits          32429   102653    +70224     
+ Misses        92949    29430    -63519     
- Partials       5070     8087     +3017     
Flag Coverage Δ
inttests 24.14% <65.51%> (?)
systests 24.77% <68.96%> (-0.09%) ⬇️
unittests 72.52% <96.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../pulsar/broker/resources/LoadBalanceResources.java 100.00% <100.00%> (ø)
...he/pulsar/broker/resources/NamespaceResources.java 80.14% <ø> (+41.41%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 72.84% <100.00%> (+61.22%) ⬆️
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 96.45% <100.00%> (+61.70%) ⬆️
...roker/loadbalance/impl/ModularLoadManagerImpl.java 81.60% <100.00%> (+24.46%) ⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 64.76% <100.00%> (+34.41%) ⬆️
...pache/pulsar/broker/resources/PulsarResources.java 84.78% <75.00%> (+1.06%) ⬆️

... and 1542 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Sep 26, 2023

@AnonHxy AnonHxy merged commit bbdc173 into apache:master Oct 8, 2023
liangyuanpeng pushed a commit to liangyuanpeng/pulsar that referenced this pull request Oct 11, 2023
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
vinayakmalik95 pushed a commit to tmdc-io/pulsar that referenced this pull request Oct 12, 2023
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants