Skip to content

[improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD #21129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 3 commits into from
Sep 25, 2023
Merged

[improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD #21129

Technoboy- merged 3 commits into from
Sep 25, 2023

Conversation

@AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Sep 5, 2023 •
edited
Loading

DISCUSS thread
VOTE thread

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@AnonHxy AnonHxy changed the title [improve][pip] PIP301: Introduce LoadBalanceResources to unify the loa… [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the loa… Sep 5, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 5, 2023
@AnonHxy AnonHxy changed the title [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the loa… [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date handle Sep 5, 2023
@AnonHxy AnonHxy changed the title [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date handle [improve][pip] PIP-301: Introduce LoadBalanceResources to unify the load-date CRUD Sep 5, 2023
@AnonHxy AnonHxy mentioned this pull request Sep 5, 2023
Merged
5 tasks
@heesung-sohn
Copy link
Contributor

heesung-sohn commented Sep 5, 2023 •
edited
Loading

LGTM.

But we also have broker-level load data too. Don't we want to add it here?

@AnonHxy AnonHxy self-assigned this Sep 6, 2023
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Sep 6, 2023

LGTM.

But we also have broker-level load data too. Don't we want to add it here?

The broeker-level data(/loadbalance/brokers/xxx) is handled by LockManager. Broker needs acquire a lock when starts. It's not a simple CRUD, so I think it's not suitable to put it here @heesung-sn

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Sep 11, 2023

@codelipenghui @merlimat @asafm @Technoboy- PTAL

@Technoboy- Technoboy- added this to the 3.2.0 milestone Sep 18, 2023
@Technoboy-
Copy link
Contributor

Technoboy- commented Sep 18, 2023

Need to update the vote thread

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Sep 18, 2023

Need to update the vote thread

OK. I will start the VOTE later.

@Technoboy- Technoboy- merged commit 5c9b72a into apache:master Sep 25, 2023
AnonHxy added a commit that referenced this pull request Oct 8, 2023
@AnonHxy
[refactor][broker] PIP-301 Part-1: Add BundleDataResources (#21119)
bbdc173 
### Motivation

See pip: #21129

### Modifications

Add  `BundleDataResources`
liangyuanpeng pushed a commit to liangyuanpeng/pulsar that referenced this pull request Oct 11, 2023
@AnonHxy @liangyuanpeng
[refactor][broker] PIP-301 Part-1: Add BundleDataResources (apache#21119
5f97f8f 
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
vinayakmalik95 pushed a commit to tmdc-io/pulsar that referenced this pull request Oct 12, 2023
@AnonHxy @vinayakmalik12
[refactor][broker] PIP-301 Part-1: Add BundleDataResources (apache#21119
4ad992f 
)

### Motivation

See pip: apache#21129

### Modifications

Add  `BundleDataResources`
@AnonHxy AnonHxy mentioned this pull request Oct 12, 2023
Merged
5 tasks
AnonHxy added a commit that referenced this pull request Oct 23, 2023
@AnonHxy
[refactor][broker ] PIP-301 Part-2: Add BrokerTimeAverageDataResources (
30d59e3 
#21353)

### Motivation

See pip: #21129

### Modifications

Add  `BrokerTimeAverageDataResources`
@AnonHxy AnonHxy mentioned this pull request Nov 6, 2023
Merged
5 tasks
@AnonHxy AnonHxy mentioned this pull request Nov 20, 2023
Merged
5 tasks
AnonHxy added a commit that referenced this pull request Dec 5, 2023
@AnonHxy
[refactor][broker] PIP-301 Part-3: Add QuotaResources (#21596)
5531524 
### Motivation

See pip: #21129

### Modifications

Add  `QuotaResources`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@congbobo184 congbobo184 congbobo184 approved these changes

Assignees

@AnonHxy AnonHxy

Labels

doc-not-needed Your PR changes do not impact docs type/PIP

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AnonHxy @heesung-sohn @Technoboy- @congbobo184