Skip to content

Conversation

@AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Oct 12, 2023

Motivation

See pip: #21129

Modifications

Add BrokerTimeAverageDataResources

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

AnonHxy#46

@AnonHxy AnonHxy changed the title [refactor][broker ]PIP-301 Part-2: Add BrokerTimeAverageDataResources [refactor][broker ] PIP-301 Part-2: Add BrokerTimeAverageDataResources Oct 12, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 12, 2023
@AnonHxy AnonHxy self-assigned this Oct 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (1a352f1) to head (6b18411).
⚠️ Report is 1617 commits behind head on master.

Files with missing lines Patch % Lines
...roker/loadbalance/impl/ModularLoadManagerImpl.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21353       +/-   ##
=============================================
+ Coverage     33.49%   73.22%   +39.73%     
+ Complexity    12257     3817     -8440     
=============================================
  Files          1636     1888      +252     
  Lines        127789   140193    +12404     
  Branches      13963    15402     +1439     
=============================================
+ Hits          42798   102658    +59860     
+ Misses        79372    29468    -49904     
- Partials       5619     8067     +2448     
Flag Coverage Δ
inttests 24.20% <55.55%> (+0.05%) ⬆️
systests 24.74% <66.66%> (?)
unittests 72.53% <88.88%> (+40.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../pulsar/broker/resources/LoadBalanceResources.java 100.00% <100.00%> (ø)
...roker/loadbalance/impl/ModularLoadManagerImpl.java 81.57% <81.81%> (+13.92%) ⬆️

... and 1530 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@lifepuzzlefun lifepuzzlefun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@HQebupt HQebupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnonHxy AnonHxy merged commit 30d59e3 into apache:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants