Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Oct 23, 2023

Motivation

There are thread leaks in tests caused by executors (thread pools) that aren't shutdown properly.

Modifications

Properly shutdown executors that have been created during test execution.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.2.0 milestone Oct 23, 2023
@lhotari lhotari self-assigned this Oct 23, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 23, 2023
@lhotari lhotari requested a review from Technoboy- October 23, 2023 18:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (a0f8b0d) to head (e8c2599).
Report is 1387 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21425       +/-   ##
=============================================
+ Coverage     34.55%   73.27%   +38.71%     
- Complexity    12083    32573    +20490     
=============================================
  Files          1711     1888      +177     
  Lines        130708   140307     +9599     
  Branches      14245    15420     +1175     
=============================================
+ Hits          45172   102811    +57639     
+ Misses        79503    29410    -50093     
- Partials       6033     8086     +2053     
Flag Coverage Δ
inttests 24.18% <ø> (?)
systests 24.76% <ø> (-0.03%) ⬇️
unittests 72.55% <ø> (+40.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1470 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit cad4e75 into apache:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants