Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented May 16, 2025

Motivation

Fixing Netty ByteBuf leaks in test code is needed for executing the plan explained in Enhancing Pulsar CI with Netty leak detection and reporting. The Pulsar CI Netty leak detection and reporting solution was added in #24272.

Modifications

  • Fix thread leaks in these tests:
    • ProxySaslAuthenticationTest (indent was also changed from tabs to spaces)
    • BookieRackAffinityMappingTest
    • RateLimiterTest
    • FileSystemOffloaderLocalFileTest
    • Fix thread leaks in tests using BookKeeperClusterTestCase base class
  • Fix ByteBuf leaks in these tests
    • FileSystemManagedLedgerOffloaderTest

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@lhotari lhotari added this to the 4.1.0 milestone May 16, 2025
@lhotari lhotari self-assigned this May 16, 2025
@apache apache deleted a comment from github-actions bot May 16, 2025
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.33%. Comparing base (bbc6224) to head (243f1ed).
Report is 1104 commits behind head on master.

Files with missing lines Patch % Lines
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24314      +/-   ##
============================================
+ Coverage     73.57%   74.33%   +0.75%     
+ Complexity    32624    32280     -344     
============================================
  Files          1877     1866      -11     
  Lines        139502   145101    +5599     
  Branches      15299    16591    +1292     
============================================
+ Hits         102638   107859    +5221     
+ Misses        28908    28722     -186     
- Partials       7956     8520     +564     
Flag Coverage Δ
inttests 26.80% <12.50%> (+2.21%) ⬆️
systests 23.35% <0.00%> (-0.98%) ⬇️
unittests 73.81% <77.77%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...filesystem/impl/FileStoreBackedReadHandleImpl.java 62.24% <100.00%> (+5.77%) ⬆️
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 59.55% <75.00%> (-21.84%) ⬇️

... and 1088 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit eccc6b6 into apache:master May 17, 2025
56 of 58 checks passed
@lhotari
Copy link
Member Author

lhotari commented May 20, 2025

skipping cherry-picking to branch-3.0 since this change depends on #21425, which isn't included in branch-3.0.

lhotari added a commit that referenced this pull request May 20, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 28, 2025
(cherry picked from commit eccc6b6)
(cherry picked from commit 1556a13)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 2, 2025
(cherry picked from commit eccc6b6)
(cherry picked from commit 1556a13)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants