-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] Fix more resource leaks in tests #24314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Fix more resource leaks in tests #24314
Conversation
- this happened at least in ManagedLedgerFactoryChangeLedgerPathTest - the BK client created by the internal DefaultBkFactory weren't closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24314 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
+ Complexity 32624 32280 -344
============================================
Files 1877 1866 -11
Lines 139502 145101 +5599
Branches 15299 16591 +1292
============================================
+ Hits 102638 107859 +5221
+ Misses 28908 28722 -186
- Partials 7956 8520 +564
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
skipping cherry-picking to branch-3.0 since this change depends on #21425, which isn't included in branch-3.0. |
(cherry picked from commit eccc6b6)
Motivation
Fixing Netty ByteBuf leaks in test code is needed for executing the plan explained in Enhancing Pulsar CI with Netty leak detection and reporting. The Pulsar CI Netty leak detection and reporting solution was added in #24272.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: