[improve][admin] Expose the offload threshold in seconds to the admin#22101
Merged
Technoboy- merged 1 commit intoapache:masterfrom Feb 23, 2024
Merged
Conversation
--- ### Motivation We have two configurations to trigger the offload automatically, time and bytes. We only expose the bytes in the admin but didn't expose the time in the admin. When we want to disable it, we need to set both of them to the -1. But we didn't expose the time settings, the offload will never be disabled.
|
@zymap Please add the following content to your PR description and select a checkbox: |
Technoboy-
approved these changes
Feb 23, 2024
yuruguo
approved these changes
Feb 23, 2024
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22101 +/- ##
=============================================
+ Coverage 37.02% 73.58% +36.55%
- Complexity 12201 32592 +20391
=============================================
Files 1734 1874 +140
Lines 132277 139354 +7077
Branches 14480 15279 +799
=============================================
+ Hits 48974 102537 +53563
+ Misses 76823 28909 -47914
- Partials 6480 7908 +1428
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hangc0276
approved these changes
Feb 23, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Feb 26, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Feb 27, 2024
Closed
15 tasks
15 tasks
Contributor
|
This PR depends on TimeUnitToSecondsConverter, which has not been cherry-picked to branch-3.0. |
Contributor
|
We are reverting this commit from branch-3.0. |
Contributor
|
@zymap Plz raise another PR to branch-3.0 without relying on TimeUnitToSecondsConverter(because TimeUnitToSecondsConverter is not available in branch-3.0), if possible. (targeting release 3.0.4) |
zymap
added a commit
to zymap/pulsar
that referenced
this pull request
Mar 1, 2024
…apache#22101) (cherry picked from commit 48c7e32)
Member
Author
|
#22169 a new PR to branch-3.0 @heesung-sn |
mukesh154
pushed a commit
to cognitree/pulsar
that referenced
this pull request
Mar 1, 2024
…he amdin (apache#22101)" This reverts commit 1fe3853.
15 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
bahetimansi
pushed a commit
to bahetimansi/pulsar
that referenced
this pull request
Mar 23, 2025
…he amdin (apache#22101)" This reverts commit 6e988ef. (cherry picked from commit ca35b2e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
We have two configurations to trigger the offload automatically, time and bytes. We only expose the bytes in the admin but didn't expose the time in the admin. When we want to disable it, we need to set both of them to the -1. But we didn't expose the time settings, the offload will never be disabled.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: