[cherry-pick] [branch-3.0] Fix getting last message ID when there are ongoing transactions

[thetumbled]

Motivation

Exception is found in branch 3.0:
#22024 (comment)

Modifications

The root is that we do not cherry pick #21466 into branch 3.0, and the test code rely on this pr.
Moreover, the test code in #21466 is merged into branch 3.0 along with my pr #22024, so we do not need to cherry pick those test code in this pr.

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#43

[github-actions]

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[thetumbled]

PTAL, thanks.
@lhotari @Technoboy-

[lhotari]

@Technoboy- I think we should cherry-pick #21466 first , that will ease tracking in the future

[lhotari]

let's first cherry-pick #21466

[thetumbled]

let's first cherry-pick #21466

may be change the title is enough?

[Technoboy-]

@Technoboy- I think we should cherry-pick #21466 first , that will ease tracking in the future

Can't cherry-pick directly. Using this and comment on the #21466 is enough

[lhotari]

Closing and reopening as an attempt to trigger the CI builds to run. For some reason, the build didn't get triggered.

[thetumbled]

Some test do not pass:
mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip=true

cannot find symbol
Error:    symbol:   class TimeUnitToSecondsConverter
Error:    location: class org.apache.pulsar.admin.cli.CmdNamespaces.SetOffloadThreshold

TimeUnitToSecondsConverter.class is introduced by #20782 , but we do not cherry pick it into branch 3.0.
However, #22101 is cherry picked into branch-3.0, which rely on TimeUnitToSecondsConverter.class.

So the solution is: first, cherry pick #20782 into branch-3.0, then we use this pr #22143 to fix the problem.
PTAL, thanks. @lhotari @Technoboy-

[thetumbled]

Some test do not pass: mvn -B -T 1C -ntp -Pcore-modules,-main clean install -DskipTests -Dlicense.skip=true -Drat.skip=true -Dcheckstyle.skip=true

cannot find symbol
Error:    symbol:   class TimeUnitToSecondsConverter
Error:    location: class org.apache.pulsar.admin.cli.CmdNamespaces.SetOffloadThreshold

TimeUnitToSecondsConverter.class is introduced by #20782 , but we do not cherry pick it into branch 3.0. However, #22101 is cherry picked into branch-3.0, which rely on TimeUnitToSecondsConverter.class.

So the solution is: first, cherry pick #20782 into branch-3.0, then we use this pr #22143 to fix the problem. PTAL, thanks. @lhotari @Technoboy-

The problem has been fixed by #22169, we can proceed with reviewing this pr. @lhotari @heesung-sn

[heesung-sohn]

I don't see this change in this cherry-pick PR.

https://github.com/apache/pulsar/pull/21466/files#diff-ecd728301a585f256e8a649b5e65b28c166194477355b3a1eefc198d014c25d3R450

@thetumbled can you check again?

[thetumbled]

I don't see this change in this cherry-pick PR.

https://github.com/apache/pulsar/pull/21466/files#diff-ecd728301a585f256e8a649b5e65b28c166194477355b3a1eefc198d014c25d3R450

@thetumbled can you check again?

Sorry for missing it. PTAL, thanks.

[lhotari]

Thank you @thetumbled for this PR. I ended up using your merge conflict resolution into this commit: 4489d03 .
I hope we find a way to fix our process that we don't end up in this problems that often in the future. I have started a discussion thread on the dev mailing list: https://lists.apache.org/thread/j6qvt45rndnvjypcmqxsfmddqt41bxjv