[fix] [broker] Fix reader stuck when read from compacted topic with read compact mode disable

[thetumbled]

Motivation

reader.hasMessageAvailable() rely on getLastMessageId to determine whether there are any messages available to read.
org.apache.pulsar.broker.service.ServerCnx#handleGetLastMessageId will read the last message from compacted topic in some cases without check if the consumer is in read compact mode.
If the consumer/reader disable the read compact mode, and the cluster enable the compaction feature, messages will be compacted into the compacted topic, but the dispactcher will not dispatch messages from compacted topic to consumer. If the messages in the original topic is expired and the consumer has nothing to be read, while the messages in the compacted topic retain alive.
reader.hasMessageAvailable() will return true as there are messages in the compacted topic, but consumer/reader will not get any messages because there are nothing in the original topic.

Modifications

reader.hasMessageAvailable() should check if the consumer is in read compact mode to determine whether get the last message id from the compacted topic.

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#38

[codelipenghui]

Nice catch!

[thetumbled]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4198ed2) 73.61% compared to head (807fd1a) 73.58%.
Report is 11 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #21969      +/-   ##
============================================
- Coverage     73.61%   73.58%   -0.03%     
- Complexity    32424    32453      +29     
============================================
  Files          1861     1863       +2     
  Lines        138678   138780     +102     
  Branches      15184    15207      +23     
============================================
+ Hits         102089   102123      +34     
- Misses        28690    28756      +66     
- Partials       7899     7901       +2     

Flag	Coverage Δ
inttests	24.10% <57.14%> (+0.01%)	⬆️
systests	23.62% <50.00%> (-0.13%)	⬇️
unittests	72.87% <78.57%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...va/org/apache/pulsar/broker/service/ServerCnx.java	72.14% <78.57%> (-0.04%)	⬇️

... and 96 files with indirect coverage changes

[heesung-sohn]

@thetumbled can you help to cherry-pick this PR to branch-3.0? I see conflicts.

[thetumbled]

@thetumbled can you help to cherry-pick this PR to branch-3.0? I see conflicts.

We have better wait #22130 to be merged, or two pr will conflict. I will help to cherry pick this pr.

[thetumbled]

@thetumbled can you help to cherry-pick this PR to branch-3.0? I see conflicts.

cherry pick in this pr: #22199