Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jun 20, 2024

Fixes #22948

Motivation

See #22948. There are 2 locations in code where producers are created in Pulsar Functions and Connectors.
The other location has been ignored for compression type support in #19470 and for crypto config in #8432.

Modifications

  • Refactor code to remove code duplication.
    • Create ProducerBuilderFactory class
      • Move crypto initialization to this class
      • Move ProducerBuilder configuration to this class
    • Use ProducerBuilderFactory to create ProducerBuilders

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari force-pushed the lh-pulsar-function-producer-config branch from 20d6298 to 612cf7a Compare June 20, 2024 08:07
@lhotari lhotari force-pushed the lh-pulsar-function-producer-config branch from 82f9268 to 2b61aa1 Compare June 20, 2024 09:24
@lhotari lhotari merged commit ada47a3 into apache:master Jun 20, 2024
lhotari added a commit that referenced this pull request Jun 20, 2024
…s in Functions and Connectors (#22950)

(cherry picked from commit ada47a3)
lhotari added a commit that referenced this pull request Jun 20, 2024
…s in Functions and Connectors (#22950)

(cherry picked from commit ada47a3)
lhotari added a commit that referenced this pull request Jun 20, 2024
…s in Functions and Connectors (#22950)

(cherry picked from commit ada47a3)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 21, 2024
…s in Functions and Connectors (apache#22950)

(cherry picked from commit ada47a3)
(cherry picked from commit 8935fef)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 24, 2024
…s in Functions and Connectors (apache#22950)

(cherry picked from commit ada47a3)
(cherry picked from commit 8935fef)
lhotari added a commit that referenced this pull request Jun 25, 2024
…s in Functions and Connectors (#22950)

(cherry picked from commit ada47a3)
(cherry picked from commit 8935fef)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 25, 2024
…s in Functions and Connectors (apache#22950)

(cherry picked from commit ada47a3)
(cherry picked from commit 8935fef)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
…s in Functions and Connectors (apache#22950)

(cherry picked from commit ada47a3)
(cherry picked from commit 8935fef)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Pulsar Functions ignores compressionType and crypto config for producers created with Context produce/newOutputMessage methods

4 participants