Fix in ConsumerBase.java to return failed future - #249 #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Mar 1, 2017
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
Change looks good, can you also add a quick unit test to verify these results?
Contributor
Author
|
Added tests - can i get a +1 please |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Signed-off-by: jonyhy96 <hy352144278@gmail.com> Fixes apache#257 ### Motivation Once the connection is closed the reconnectToBroker logic of both producer and consumer will try to reconnect to the broker infinatly. ### Modifications Add a field in the Options represent the max number of retries and not break current behavior if this field is not fullfilled.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 14, 2024
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix for Issue #249
Modifications
Added return statements
Result
Failed futures will be returned if the consumer is not ready