Removing Inner structs in cpp client #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Apr 17, 2017
jai1
force-pushed
the
CreatingWrapperForCPP
branch
from
55a89ab to
70bae90
Compare
saandrews
approved these changes
Apr 17, 2017
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Signed-off-by: jonyhy96 <hy352144278@gmail.com> Fixes apache#257 ### Motivation Once the connection is closed the reconnectToBroker logic of both producer and consumer will try to reconnect to the broker infinatly. ### Modifications Add a field in the Options represent the max number of retries and not break current behavior if this field is not fullfilled.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
* Add maintainers from community * Fix indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Want to remove the deprecation flags, methods and -Dpulsar=cms and create a wrapper for Yahoo CPP users like we have for Java.
Since in CPP we can’t forward declare inner classes I can’t forward declare pulsar::ProducerConfiguration::Impl And add it to my wrapper i.e https://gist.github.com/jai1/9bfa90ee237a9e2ca7a175e893cf4faa is not possible - hence the changes.
Modifications
Created separate files for
a. ClientConfiguration.h
b. ProducerConfiguration.h
c. ConsumerConfiguration.h
d. CompressionType.h
Created Separate Impl for
a. ClientConfigurationImpl.h
b. ProducerConfigurationImpl.h
c. ConsumerConfigurationImpl.h
Removed deprecated flags and methods from client
Result
Noop from user perspective and the binary compatibility is also not broken.