Allow to build Pulsar on JDK14+ #7951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is not intended to make tests pass, only to allow a full clean build. |
Contributor
Author
|
rerun failure tests |
rdhabalia
approved these changes
Sep 1, 2020
Contributor
|
/pulsarbot run-failure-checks |
Contributor
Author
|
thank you @rdhabalia |
codelipenghui
approved these changes
Sep 2, 2020
Contributor
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Sep 2, 2020
Member
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Sep 3, 2020
Member
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
|
/pulsarbot run-failure-checks |
Member
|
/pulsarbot run-failure-checks |
Contributor
Author
|
Is it normal this series of failures ? |
Contributor
Author
|
/pulsarbot run-failure-checks |
eolivelli
force-pushed
the
fix/build-jdk14
branch
from
9c18281 to
15d5e04
Compare
Contributor
Author
|
The upgrade of plugins determined changes in the final output of the binaries. |
eolivelli
force-pushed
the
fix/build-jdk14
branch
from
15d5e04 to
d2315f9
Compare
- update Apache Maven Assembly Plugin - use explicit import for Record class (prevent clash with java.lang.Record)
eolivelli
force-pushed
the
fix/build-jdk14
branch
from
d2315f9 to
1313abd
Compare
added 2 commits
October 22, 2020 09:41
eolivelli
changed the title
Contributor
Author
|
/pulsarbot run-failure-checks |
eolivelli
force-pushed
the
fix/build-jdk14
branch
from
8c39a47 to
2617144
Compare
Contributor
Author
|
I cannot reproduce CI errors locally, opening a new PR #8360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently Pulsar does not build on JDK14
Modifications
Verifying this change
This change is already covered by existing tests