Skip to content

Allow building Apache Pulsar on JDK15+ - upgrade Maven Assembly Plugin #8360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiazhai merged 9 commits into from
Oct 29, 2020
Merged

Allow building Apache Pulsar on JDK15+ - upgrade Maven Assembly Plugin #8360

jiazhai merged 9 commits into from
Oct 29, 2020

Conversation

@eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Oct 23, 2020 •
edited
Loading

Motivation

Currently Pulsar does not build on JDK15

Modifications

  • update Maven Assembly plugin
  • move maven-git-commit-id plugin execution only inside Pulsar Common (in order to speed up the build)
  • upgrading the Maven Assembly Plugin resulted in a different output for the "binaries", I had to update license files
  • forced version of Jersey to 2.31 in "Presto" distribution (otherwise the license check failed, because it does not handle different versions between main pulsar binaries and presto distribution inside lib/presto/lib, and this makes sense to me)

Verifying this change

This change is already covered by existing tests

@eolivelli eolivelli mentioned this pull request Oct 23, 2020
Closed
@lhotari
Copy link
Member

lhotari commented Oct 23, 2020

it looks like github actions cached some content, as I cannot reproduce locally license check failures and compilation errors in integration test

@eolivelli I believe #8361 fixes the grpc version issues in master branch. I cherry picked the commit to another PR that I'm working to test it. #8362 is the reason why master branch got into a broken state.

@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 23, 2020

Good to know.
Waiting for master to be restored before pushing other changes

@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 24, 2020

/pulsarbot run-failure-checks

Enrico Olivelli added 5 commits October 25, 2020 13:44
@eolivelli
Allow to build Pulsar on JDK14+
52982d8 
- update Apache Maven Assembly Plugin
- use explicit import for Record class (prevent clash with java.lang.Record)
@eolivelli
revert Apache pom update
c3dde27
@eolivelli
fix
4822fdd
@eolivelli
Fix presto distribution - due to maven assembly plugin upgrade
5aacfff
@eolivelli
fix licenses
fdc3cd2
@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 25, 2020

rebased onto current master, let's see CI again

@eolivelli eolivelli mentioned this pull request Oct 26, 2020
Merged
@eolivelli eolivelli changed the title Allow building Apache Pulsar on JDK15+ Allow building Apache Pulsar on JDK15+ - upgrade Maven Assembly Plugin Oct 27, 2020
@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 27, 2020

@lhotari test failed with this error
Error: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:unpack (unpack) on project pulsar-client: Execution unpack of goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:3.1.1 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven.shared:file-management:jar:3.0.0 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/shared/file-management/3.0.0/file-management-3.0.0.jar: Connection reset -> [Help 1]

probably your fix #8386 will help

@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 27, 2020

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.7.0 milestone Oct 27, 2020
@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 28, 2020

/pulsarbot run-failure-checks

@eolivelli eolivelli mentioned this pull request Oct 28, 2020
Merged
@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 28, 2020

One job fails with
Error: Failed to execute goal on project pulsar-io-hbase: Could not resolve dependencies for project org.apache.pulsar:pulsar-io-hbase:jar:2.7.0-SNAPSHOT: Failed to collect dependencies at org.apache.hbase:hbase-server:jar:2.3.0 -> org.glassfish.web:javax.servlet.jsp:jar:2.3.2 -> org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT: Failed to read artifact descriptor for org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT: Could not transfer artifact org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT from/to spring-plugins-release (https://repo.spring.io/plugins-release/): Failed to transfer file https://repo.spring.io/plugins-release/org/glassfish/javax.el/3.0.1-b06-SNAPSHOT/javax.el-3.0.1-b06-SNAPSHOT.pom with status code 502 -> [Help 1]

@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 28, 2020

/pulsarbot run-failure-checks

@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 28, 2020

/pulsarbot run-failure-checks

1 similar comment
@eolivelli
Copy link
Contributor Author

eolivelli commented Oct 29, 2020

/pulsarbot run-failure-checks

@jiazhai jiazhai merged commit b527ccc into apache:master Oct 29, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
@eolivelli @huangdx0726
Allow building Apache Pulsar on JDK15+ - upgrade Maven Assembly Plugin (
3e6abf7 
apache#8360)

Motivation
Currently Pulsar does not build on JDK15

Modifications
update Maven Assembly plugin
move maven-git-commit-id plugin execution only inside Pulsar Common (in order to speed up the build)
upgrading the Maven Assembly Plugin resulted in a different output for the "binaries", I had to update license files
forced version of Jersey to 2.31 in "Presto" distribution (otherwise the license check failed, because it does not handle different versions between main pulsar binaries and presto distribution inside lib/presto/lib, and this makes sense to me)
Verifying this change
This change is already covered by existing tests


* Allow to build Pulsar on JDK14+
- update Apache Maven Assembly Plugin
- use explicit import for Record class (prevent clash with java.lang.Record)

* revert Apache pom update

* fix

* Fix presto distribution - due to maven assembly plugin upgrade

* fix licenses

* Fix kafka clients

* fix LICENSE

Co-authored-by: Enrico Olivelli <enrico.olivelli@diennea.com>
Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
@eolivelli @flowchartsman
Allow building Apache Pulsar on JDK15+ - upgrade Maven Assembly Plugin (
0ae61a8 
apache#8360)

Motivation
Currently Pulsar does not build on JDK15

Modifications
update Maven Assembly plugin
move maven-git-commit-id plugin execution only inside Pulsar Common (in order to speed up the build)
upgrading the Maven Assembly Plugin resulted in a different output for the "binaries", I had to update license files
forced version of Jersey to 2.31 in "Presto" distribution (otherwise the license check failed, because it does not handle different versions between main pulsar binaries and presto distribution inside lib/presto/lib, and this makes sense to me)
Verifying this change
This change is already covered by existing tests


* Allow to build Pulsar on JDK14+
- update Apache Maven Assembly Plugin
- use explicit import for Record class (prevent clash with java.lang.Record)

* revert Apache pom update

* fix

* Fix presto distribution - due to maven assembly plugin upgrade

* fix licenses

* Fix kafka clients

* fix LICENSE

Co-authored-by: Enrico Olivelli <enrico.olivelli@diennea.com>
Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@eolivelli eolivelli

Labels

area/build

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@eolivelli @lhotari @merlimat @sijie @jiazhai