Do not use "star import" for org.apache.pulsar.functions.api.Record in order to be able to build Pulsar on JDK14+ #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

merlimat merged 3 commits into apache:master from eolivelli:fix/build-jdk15-part1

Oct 26, 2020

Contributor

eolivelli commented Oct 26, 2020

Motivation

JDK14 introduced java.lang.Record, that is imported by default as "Record".
The build fails in some .java files due to the ambiguity between org.apache.pulsar.functions.api.Record and java.lang.Record.

Modifications

Use explicit imports instead of star import, only in the Java files that break the build.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Enrico Olivelli added 3 commits

October 26, 2020 08:18


          Allow to build Pulsar on JDK14

c52469e

- update Apache Parent Maven Pom to latest (upgrade plugins)
- use explicit import for Record class (prevent clash with java.lang.Record)

xx

9a69584


          revert pom changes

97eab8b

Contributor Author

eolivelli commented Oct 26, 2020

I am trying to split the patch into smaller pieces because in #8360 integration tests and other CI jobs does not pass, probably due to the upgrade of the Maven Assembly plugin.
I am going to send a separate patch for the Maven Assembly Plugin stuff.

@merlimat you already approved #8360, hopefully here the tests will pass without problem (otherwise we have serious issues on CI), PTAL and merge if you can. thanks in advance

cc @codelipenghui @rdhabalia @jiazhai

Contributor Author

eolivelli commented Oct 26, 2020

/pulsarbot rerun-failure-checks

2 similar comments

Contributor Author

eolivelli commented Oct 26, 2020

/pulsarbot rerun-failure-checks

Contributor Author

eolivelli commented Oct 26, 2020

/pulsarbot rerun-failure-checks

Contributor Author

eolivelli commented Oct 26, 2020

I am seeing the same failure many times
#8374
I will address the issue in a separate patch

Contributor Author

eolivelli commented Oct 26, 2020

/pulsarbot rerun-failure-checks

2 similar comments

Contributor Author

eolivelli commented Oct 26, 2020

/pulsarbot rerun-failure-checks

Contributor Author

eolivelli commented Oct 26, 2020

/pulsarbot rerun-failure-checks

Contributor Author

eolivelli commented Oct 26, 2020

I have sent a separate fix for the flaky test
#8379

merlimat approved these changes

View reviewed changes

merlimat added the area/build label

merlimat added this to the 2.7.0 milestone

sijie assigned eolivelli

sijie approved these changes

View reviewed changes

Member

sijie left a comment

@eolivelli the change looks good! But I think we should also consider enabling checkstyle across module to enforce consistent styles. There are some modules already running checkstyle. Are you interested in contributing code changes to enable them?

Contributor Author

eolivelli commented Oct 26, 2020

I had another change about upgrading checkstyle to latest version.
It would be a quite huge patch (and boring work) because they changed the ImportOrder rule

merlimat merged commit c6560ee into apache:master

eolivelli deleted the fix/build-jdk15-part1 branch

October 27, 2020 14:14

huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request


          Do not use "star import" for org.apache.pulsar.functions.api.Record i…

45e8755

…n order to be able to build Pulsar on JDK14+ (apache#8370)

* Allow to build Pulsar on JDK14
- update Apache Parent Maven Pom to latest (upgrade plugins)
- use explicit import for Record class (prevent clash with java.lang.Record)

* xx

* revert pom changes

Co-authored-by: Enrico Olivelli <enrico.olivelli@diennea.com>

flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request


          Do not use "star import" for org.apache.pulsar.functions.api.Record i…

f2e4924

…n order to be able to build Pulsar on JDK14+ (apache#8370)

* Allow to build Pulsar on JDK14
- update Apache Parent Maven Pom to latest (upgrade plugins)
- use explicit import for Record class (prevent clash with java.lang.Record)

* xx

* revert pom changes

Co-authored-by: Enrico Olivelli <enrico.olivelli@diennea.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels