Skip to content

Conversation

@eolivelli
Copy link
Contributor

Fixes #8473

Modifications

Parse explicitly Prometheus "+Inf" and "-Inf"

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

@eolivelli
Copy link
Contributor Author

The problem was introduced probably with #6814
@codelipenghui @hangc0276 PTAL

Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, Thanks for the fix.

@sijie sijie added this to the 2.7.0 milestone Oct 26, 2020
@merlimat
Copy link
Contributor

@eolivelli

There's a compilation error:

PrometheusMetricsTest.java:[584,24] variable value is already defined in method parseMetrics(java.lang.String)

@merlimat merlimat merged commit 90242fd into apache:master Oct 26, 2020
@eolivelli eolivelli deleted the fix/issue-8374 branch October 27, 2020 14:14
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
…apache#8379)

* Issue 8473: testManagedLedgerBookieClientStats fails very often on CI

* Fix build

Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
…apache#8379)

* Issue 8473: testManagedLedgerBookieClientStats fails very often on CI

* Fix build

Co-authored-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants