[Issue 8346][Admin API] Validate retention policy #8358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
since master branch is broken atm, I cherry picked the commit from #8361 to fix the broken state of CI. That PR should be merged before this one. |
Member
Author
|
/pulsarbot run-failure-checks |
sijie
reviewed
Oct 23, 2020
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
I'm running an experiment to see if reverting 647d3c2 fixes the grpc / protobuf compatibility issues. |
Fixes apache#8346 - prevent setting invalid retention policy where either size or time limit is set to zero while the other limit has a non-zero value. - the reason for this is that setting either size or time limit to zero will effectively disable the retention policy. - it is confusing for the end-user if it's possible to set a value for the other limit while it's ignored when the other limit has the value of zero
lhotari
force-pushed
the
lh-validate-retention-policies
branch
from
30aa4c8 to
12a463a
Compare
Contributor
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
6 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
Fixes apache#8346 ### Motivation See apache#8346, apache#8345 ### Modifications Prevent setting invalid retention policy where either size or time limit is set to zero while the other limit has a non-zero value. The reason for this is that setting either size or time limit to zero will effectively disable the retention policy. It is confusing for the end-user if it's possible to set a value for the other limit while it's ignored when the other limit has the value of zero. This might lead to the incorrect assumption that the value of 0 has the meaning that the limit isn't effective. The validation will provide the Admin API end user a useful error message if the validation fails.
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
Fixes apache#8346 ### Motivation See apache#8346, apache#8345 ### Modifications Prevent setting invalid retention policy where either size or time limit is set to zero while the other limit has a non-zero value. The reason for this is that setting either size or time limit to zero will effectively disable the retention policy. It is confusing for the end-user if it's possible to set a value for the other limit while it's ignored when the other limit has the value of zero. This might lead to the incorrect assumption that the value of 0 has the meaning that the limit isn't effective. The validation will provide the Admin API end user a useful error message if the validation fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8346
Motivation
See #8346, #8345
Modifications
Prevent setting invalid retention policy where either size or time limit is set to zero while the other limit has a non-zero value.
The reason for this is that setting either size or time limit to zero will effectively disable the retention policy.
It is confusing for the end-user if it's possible to set a value for the other limit while it's ignored when the other limit has
the value of zero. This might lead to the incorrect assumption that the value of 0 has the meaning that the limit isn't effective.
The validation will provide the Admin API end user a useful error message if the validation fails.