Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
sijie
requested review from
315157973,
codelipenghui,
hangc0276,
jiazhai,
merlimat and
murong00
Contributor
Author
|
/pulsarbot run-failure-checks |
murong00
approved these changes
Feb 4, 2021
Signed-off-by: Renkai <gaelookair@gmail.com>
Member
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
sijie
added
the
type/cleanup
sijie
approved these changes
Feb 8, 2021
codelipenghui
added
release/2.7.1
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Apr 27, 2021
…ined
- don't pass -Dio.netty.* system properties if PULSAR_EXTRA_OPTS or
BOOKIE_EXTRA_OPTS is set
- this is to be consistent with PULSAR_EXTRA_OPTS behavior and
to prevent duplicate properties
- add "-Dio.netty.leakDetectionLevel=disabled" unless BOOKIE_EXTRA_OPTS
is set since PULSAR_EXTRA_OPTS doesn't include that setting by default
- apache#9469 introduced a breaking change by changing the behavior
This was referenced Apr 27, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2021
…ined (#10397) ### Motivation - #9469 introduced a breaking change by changing the behavior . This change was part of 2.7.1 release. ### Modifications - fallback to `PULSAR_EXTRA_OPTS` if `BOOKIE_EXTRA_OPTS` isn't defined - don't pass `-Dio.netty.*` system properties if `PULSAR_EXTRA_OPTS` or `BOOKIE_EXTRA_OPTS` is set - this is to be consistent with `PULSAR_EXTRA_OPTS` behavior and to prevent duplicate properties - add `-Dio.netty.leakDetectionLevel=disabled` unless `BOOKIE_EXTRA_OPTS` is set since `PULSAR_EXTRA_OPTS` doesn't include that setting by default. (`simple` is the default if the property isn't set) ### Other context - It is also necessary to cherry-pick #9621 to restore backwards compatibility in 2.7.x branch.
eolivelli
pushed a commit
that referenced
this pull request
Apr 28, 2021
…ined (#10397) ### Motivation - #9469 introduced a breaking change by changing the behavior . This change was part of 2.7.1 release. ### Modifications - fallback to `PULSAR_EXTRA_OPTS` if `BOOKIE_EXTRA_OPTS` isn't defined - don't pass `-Dio.netty.*` system properties if `PULSAR_EXTRA_OPTS` or `BOOKIE_EXTRA_OPTS` is set - this is to be consistent with `PULSAR_EXTRA_OPTS` behavior and to prevent duplicate properties - add `-Dio.netty.leakDetectionLevel=disabled` unless `BOOKIE_EXTRA_OPTS` is set since `PULSAR_EXTRA_OPTS` doesn't include that setting by default. (`simple` is the default if the property isn't set) ### Other context - It is also necessary to cherry-pick #9621 to restore backwards compatibility in 2.7.x branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #9433