[Bookie] Fallback to PULSAR_GC if BOOKIE_GC is not defined#9621
Merged
merlimat merged 1 commit intoapache:masterfrom Feb 19, 2021
Merged
[Bookie] Fallback to PULSAR_GC if BOOKIE_GC is not defined#9621merlimat merged 1 commit intoapache:masterfrom
merlimat merged 1 commit intoapache:masterfrom
Conversation
- Currently Bookies fallback to PULSAR_MEM if BOOKIE_MEM isn't set (apache#6201). For consistency, it's useful to fallback to PULSAR_GC if BOOKIE_GC isn't set.
Member
Author
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Feb 19, 2021
Member
Author
|
@eolivelli This and #10397 is needed in 2.7.2 because #9469 in 2.7.1 causes issues for users upgrading to 2.7.x . There's a slack discussion about it. |
eolivelli
pushed a commit
that referenced
this pull request
Apr 27, 2021
- Currently Bookies fallback to PULSAR_MEM if BOOKIE_MEM isn't set (#6201). For consistency, it's useful to fallback to PULSAR_GC if BOOKIE_GC isn't set.
eolivelli
added
cherry-picked/branch-2.7
Contributor
|
@lhotari I have cherry picked to branch-2.7, it will be available on 2.7.2 |
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2021
…ined (#10397) ### Motivation - #9469 introduced a breaking change by changing the behavior . This change was part of 2.7.1 release. ### Modifications - fallback to `PULSAR_EXTRA_OPTS` if `BOOKIE_EXTRA_OPTS` isn't defined - don't pass `-Dio.netty.*` system properties if `PULSAR_EXTRA_OPTS` or `BOOKIE_EXTRA_OPTS` is set - this is to be consistent with `PULSAR_EXTRA_OPTS` behavior and to prevent duplicate properties - add `-Dio.netty.leakDetectionLevel=disabled` unless `BOOKIE_EXTRA_OPTS` is set since `PULSAR_EXTRA_OPTS` doesn't include that setting by default. (`simple` is the default if the property isn't set) ### Other context - It is also necessary to cherry-pick #9621 to restore backwards compatibility in 2.7.x branch.
eolivelli
pushed a commit
that referenced
this pull request
Apr 28, 2021
…ined (#10397) ### Motivation - #9469 introduced a breaking change by changing the behavior . This change was part of 2.7.1 release. ### Modifications - fallback to `PULSAR_EXTRA_OPTS` if `BOOKIE_EXTRA_OPTS` isn't defined - don't pass `-Dio.netty.*` system properties if `PULSAR_EXTRA_OPTS` or `BOOKIE_EXTRA_OPTS` is set - this is to be consistent with `PULSAR_EXTRA_OPTS` behavior and to prevent duplicate properties - add `-Dio.netty.leakDetectionLevel=disabled` unless `BOOKIE_EXTRA_OPTS` is set since `PULSAR_EXTRA_OPTS` doesn't include that setting by default. (`simple` is the default if the property isn't set) ### Other context - It is also necessary to cherry-pick #9621 to restore backwards compatibility in 2.7.x branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PULSAR_MEMwhenBOOKIE_MEMisn't set ([ISSUE-6131]: Ensure JVM memory and GC options are set for bookie #6201).For consistency, it's useful to fall back to
PULSAR_GCifBOOKIE_GCisn't set.
Modifications
Change
conf/bkenv.shto handleBOOKIE_GCsimilarly asBOOKIE_MEMis handled, falling back toPULSAR_*.