SAMZA-2332: [AM isolation] YarnJob should pass new command and additional environment variables for AM deployment #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variables for AM deployment
cameronlee314
changed the title
cameronlee314
commented
Sep 27, 2019
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestYarnJob.java
Outdated
Show resolved
Hide resolved
prateekm
requested changes
Oct 7, 2019
samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolationUtils.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/config/JobConfig.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/scala/org/apache/samza/config/ShellCommandConfig.scala
Outdated
Show resolved
Hide resolved
…pplication master isolation
Contributor
|
@shanthoosh FYI |
Contributor
Author
Just to make sure we are on the same page: The changes for SQL aren't going to immediately leverage general split deployment, because SQL does not want to make general split deployment a dependency right now. Eventually, SQL would converge to using general split deployment, but not right now. |
Contributor
|
@cameronlee314 Yup. @shanthoosh had a question about whether AM split deploy will continue working when we move planning to the AM, or if there would be further changes required. |
rmatharu-zz
pushed a commit
to rmatharu-zz/samza
that referenced
this pull request
Oct 23, 2019
…onal environment variables for AM deployment (apache#1172)
cameronlee314
added a commit
that referenced
this pull request
Apr 28, 2021
Issues: Some code was added for SEP-24 some time ago (#1172, #1173), but we are not moving forward with SEP-24 because it does not cleanly handle certain use cases. Since we don't need this code, it should get removed. Changes: 1. Removed unused flows related to job coordinator dependency isolation. 2. Removed unused classloader separation utils. API changes and usage/upgrade instructions: Removed some configs and environment variables related to split deployment, but the feature wasn't complete, so those shouldn't be used by Samza jobs anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.