SAMZA-2333: [AM isolation] Use cytodynamics classloader to launch job coordinator #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variables for AM deployment
cameronlee314
commented
Sep 27, 2019
prateekm
reviewed
Oct 7, 2019
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/clustermanager/ClusterBasedJobCoordinator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Outdated
Show resolved
Hide resolved
…pplication master isolation
Contributor
|
@shanthoosh FYI |
prateekm
approved these changes
Nov 25, 2019
Contributor
prateekm
left a comment
prateekm
left a comment
There was a problem hiding this comment.
Looks good, thanks. Minor feedback, feel free to accept/ignore and merge.
samza-core/src/main/java/org/apache/samza/classloader/DependencyIsolationUtils.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/classloader/IsolatingClassLoaderFactory.java
Show resolved
Hide resolved
rmatharu-zz
pushed a commit
to rmatharu-zz/samza
that referenced
this pull request
Jan 21, 2020
cameronlee314
added a commit
that referenced
this pull request
Apr 28, 2021
Issues: Some code was added for SEP-24 some time ago (#1172, #1173), but we are not moving forward with SEP-24 because it does not cleanly handle certain use cases. Since we don't need this code, it should get removed. Changes: 1. Removed unused flows related to job coordinator dependency isolation. 2. Removed unused classloader separation utils. API changes and usage/upgrade instructions: Removed some configs and environment variables related to split deployment, but the feature wasn't complete, so those shouldn't be used by Samza jobs anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses cytodynamics to load Samza framework code from a different package than the Samza application. This allows dependencies to be isolated between framework code and application code. This flow is only enabled by setting the config
samza.cluster.based.job.coordinator.dependency.isolation.enabled.Made the following changes to samza-hello-samza to test this: