SAMZA-1874: Refactor SamzaContainer and TaskInstance unit tests to make shared context changes easier #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke shared context changes easier
prateekm vjagadish1989 whenever you get a chance. This is an initial set of mostly minor changes. Author: Ahmed Abdul Hamid <ahabdulh@ahabdulh-mn1.linkedin.biz> Reviewers: Jagadish<jagadish@apache.org> Closes apache#623 from ahmedahamid/dev/ahabdulh/execution-planner-stylistic-improv
Add common retry functionality to table IO functions for data stores that do not have native retry support. We use failsafe as the retry library. Author: Peng Du <pdu@linkedin.com> Reviewers: Xinyu Liu <xinyu@apache.org> Closes apache#618 from pdu-mn1/retry-support
…de for repartitioning the stream Author: Aditya Toomula <atoomula@linkedin.com> Reviewers: Srinivasulu Punuru <spunuru@linkedin.com> Closes apache#643 from atoomula/join-serde
Contributor
Author
|
@vjagadish1989 @prateekm can you please review this? |
prateekm
approved these changes
Sep 18, 2018
Contributor
prateekm
left a comment
prateekm
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup. A few minor comments.
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstanceExceptionHandler.scala
Outdated
Show resolved
Hide resolved
samza-core/src/test/scala/org/apache/samza/system/chooser/MockSystemAdmin.scala
Show resolved
Hide resolved
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala
Show resolved
Hide resolved
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala
Outdated
Show resolved
Hide resolved
…ke shared context changes easier
…ub.com/cameronlee314/samza into refactor_unit_tests_for_shared_context
Contributor
Author
|
I accidentally messed up this branch with some accidental rebasing and merging. I'm going to close this one and create a new PR with the proper commits just to make sure everything gets reset properly. |
Contributor
Author
|
This is replaced by #646 |
asfgit
pushed a commit
that referenced
this pull request
Sep 19, 2018
…ke shared context changes easier This replaces #638, I accidentally messed up that branch. The difference between this PR and the last review by prateekm is 5d55299 Author: Cameron Lee <calee@linkedin.com> Reviewers: Prateek Maheshwari <pmaheshwari@apache.org> Closes #646 from cameronlee314/refactor_unit_tests_for_shared_context_new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.