[SANTUARIO-614] Tests for the EC Brainpool key types #298
Conversation
…security-java into SANTUARIO-614_implement-tests-for-brainpool-keytypes
add eddsa.jks key creation command to README.txt
coheigea
left a comment
coheigea
left a comment
There was a problem hiding this comment.
Is it possible to generate the encryption keys dynamically rather than using a keystore?
|
@coheigea The new tests are carried out using the identical "test pattern" employed for other key types". And these tests uses the certificates, not just the keys . Is there a particular reason why the keystore approach is not suitable Certificates using this type of key? |
|
@coheigea, I am not sure if this helps, but I updated the instructions for generating certificates, now "the instruction" is using openssl because java/keytool doesn't support these EC key types anymore. |
seanjmullan
left a comment
seanjmullan
left a comment
There was a problem hiding this comment.
LGTM. If possible, please fix the typo in the Subject before integrating: s/SANTUIARIO/SANTUARIO/
Also, the subject of SANTUARIO-614 is "edelivery AS4 profile with the brainpool EC keytypes" - I think it should match the title of this PR, which better reflects the change: "Tests for the EC Brainpool key types"
jrihtarsic
changed the title
* [SANTUIARIO-614] Tests for the EC Brainpool key types * Update XMLSignatureBrainpoolTest with XMLSignatureAbstract add eddsa.jks key creation command to README.txt * PR: Update instruction how brainpool.p12 is generated using the openssl + fix typo --------- Co-authored-by: RIHTARSIC Joze <joze.rihtarsic@ext.ec.europa.eu>
3 participants
The purpose of the contributions is to verify (and implement unit tests) for signing and encryption with the EC Brainpool key types.
For details see the PR #293 and SANTUARIO-614
The code is contributed on behalf of the European Commission’s edelivery project to support eDelivery AS4 2.0 profile.