[SANTUARIO-611] Add support of ECDSA with SHA3 algorithms #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanjmullan
reviewed
Mar 27, 2024
Member
seanjmullan
left a comment
seanjmullan
left a comment
There was a problem hiding this comment.
Code changes look good. It would be nice to also include a test for these algorithms using the javax.xml.crypto APIs.
Contributor
Author
|
Sure, I added them now (I should already know this by now :) ) I updated the test class |
seanjmullan
approved these changes
Mar 29, 2024
Member
seanjmullan
left a comment
seanjmullan
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the test restructuring.
@coheigea can you also review this PR?
coheigea
approved these changes
Apr 8, 2024
coheigea
pushed a commit
that referenced
this pull request
Apr 8, 2024
* [SANTUARIO-611] Add support of ECDSA with SHA3 algorithms * [SANTUARIO-611] update tests using javax.xml.crypto APIs. --------- Co-authored-by: RIHTARSIC Joze <joze.rihtarsic@ext.ec.europa.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ECDSA SHA3 signatures:
For details see the ticker: SANTUARIO-611