Skip to content

Support start with and end with#47

Merged
wu-sheng merged 1 commit intoapache:masterfrom
nisiyong:support-start-end
Nov 17, 2022
Merged

Support start with and end with#47
wu-sheng merged 1 commit intoapache:masterfrom
nisiyong:support-start-end

Conversation

@nisiyong
Copy link
Copy Markdown
Contributor

@nisiyong nisiyong commented Nov 17, 2022

Related to apache/skywalking-java#382.

Here are the brief changes:

  1. Introduce the enum ExpressOperator to refactor ExpressParser
  2. Support start with and end with operators
  3. Fix wrong spelling

mrproliu
mrproliu approved these changes Nov 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@wu-sheng wu-sheng merged commit 2900625 into apache:master Nov 17, 2022
@nisiyong nisiyong deleted the support-start-end branch November 17, 2022 07:17
@nisiyong nisiyong mentioned this pull request Nov 17, 2022
Merged
1 task
@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Nov 18, 2022 •
edited
Loading

I am going to revert this change. @nisiyong Please polish the logic.

wu-sheng added a commit that referenced this pull request Nov 18, 2022
@wu-sheng
Revert "Support start with and end with (#47)"
6203279 
This reverts commit 2900625.
@wu-sheng wu-sheng mentioned this pull request Nov 18, 2022
Merged
wu-sheng added a commit that referenced this pull request Nov 18, 2022
@wu-sheng
Revert "Support start with and end with (#47)" (#48)
fbba0a4 
This reverts commit 2900625.
@nisiyong
Copy link
Copy Markdown
Contributor Author

nisiyong commented Nov 18, 2022

Okay

nisiyong added a commit to nisiyong/skywalking-agent-test-tool that referenced this pull request Nov 18, 2022
@nisiyong
Support start with and end with (apache#47)
489291b 
* Introduce the enum ExpressOperator to refactor ExpressParser
* Support start with and end with operators
* Fix wrong spelling
@nisiyong nisiyong mentioned this pull request Nov 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@mrproliu mrproliu mrproliu approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nisiyong @wu-sheng @mrproliu @kezhenxu94