Upgrade agent-test-tools and polish dubbo plugin#387
Conversation
|
@nisiyong It seems the tool change breaks. |
I will take a look. |
* upgrade skywalking-agent-test-tools * change dubbo thread name * polish test case
04e2325 to
e99e268
Compare
|
Finally, the agent-test-tools has fixed the prefix bug. And at the same time, I found public class MeterId {
...
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
MeterId meterId = (MeterId) o;
return Objects.equals(name, meterId.name) &&
Objects.equals(tags, meterId.tags);
}
}So I am not going to change the dubbo thread pool name, but the agent-test-tools still support the new operators |
|
I am not very clear why |
All the operator could work well at the expected value. But in the meter scenario, the test-tools will find the same meter first, then compare the meter value. The same meters must have the same tag-keys and the same tag-value, that's why |
|
The agent-test -tools repo URL and revision has be updated. All things are done, @wu-sheng please take a look. |
start withandend withskywalking-agent-test-tool#47CHANGESlog.