Skip to content

Upgrade agent-test-tools and polish dubbo plugin#387

Merged
wu-sheng merged 6 commits intoapache:mainfrom
nisiyong:upgrade-test-tools
Nov 19, 2022
Merged

Upgrade agent-test-tools and polish dubbo plugin#387
wu-sheng merged 6 commits intoapache:mainfrom
nisiyong:upgrade-test-tools

Conversation

@nisiyong
Copy link
Copy Markdown
Contributor

@nisiyong nisiyong commented Nov 17, 2022

@wu-sheng wu-sheng added enhancement New feature or request plugin labels Nov 17, 2022
@wu-sheng wu-sheng added this to the 8.14.0 milestone Nov 17, 2022
@wu-sheng wu-sheng closed this Nov 18, 2022
@wu-sheng wu-sheng reopened this Nov 18, 2022
@wu-sheng
Copy link
Copy Markdown
Member

@nisiyong It seems the tool change breaks.

@nisiyong
Copy link
Copy Markdown
Contributor Author

@nisiyong It seems the tool change breaks.

I will take a look.

Comment thread test/plugin/agent-test-tools/pom.xml Outdated
@nisiyong
Copy link
Copy Markdown
Contributor Author

Finally, the agent-test-tools has fixed the prefix bug. And at the same time, I found start with or not blank couldn't use at the MeterItems tag value, because the MeterId will compare with the MeterItems tag value.

MeterId.java

public class MeterId {
    ...
    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;
        MeterId meterId = (MeterId) o;
        return Objects.equals(name, meterId.name) &&
            Objects.equals(tags, meterId.tags);
    }
}

So I am not going to change the dubbo thread pool name, but the agent-test-tools still support the new operators start with and end with in other cases.

@wu-sheng
Copy link
Copy Markdown
Member

I am not very clear why eq works, but start with not?

@nisiyong
Copy link
Copy Markdown
Contributor Author

I am not very clear why eq works, but start with not?

All the operator could work well at the expected value. But in the meter scenario, the test-tools will find the same meter first, then compare the meter value. The same meters must have the same tag-keys and the same tag-value, that's why MeterId#equals compare with tags and MeterId.Tag#equals compared with tag-key and tag-value.

@nisiyong
Copy link
Copy Markdown
Contributor Author

The agent-test -tools repo URL and revision has be updated. All things are done, @wu-sheng please take a look.

@wu-sheng wu-sheng merged commit c90d24e into apache:main Nov 19, 2022
@nisiyong nisiyong deleted the upgrade-test-tools branch November 19, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants