Add customer parameter for java agent config "agent.namespace"#29
Closed
861763765 wants to merge 5 commits intoapache:masterfrom
861763765:master
Closed
Add customer parameter for java agent config "agent.namespace"#29861763765 wants to merge 5 commits intoapache:masterfrom 861763765:master
861763765 wants to merge 5 commits intoapache:masterfrom
861763765:master
Conversation
…ent.namespace" in agent.config
Author
|
Add the customer parameter for java agent config "agent.namespace", so we can use the traceId from nginx to backend(java) server. |
wu-sheng
reviewed
Apr 3, 2020
| -- The parameter "customer_namespace" for java agent config "agent.namespace" | ||
| ------------------------------------------------------ | ||
| require("tracer"):start("upstream service") | ||
| require("tracer"):start("upstream service", "customer_namespace") |
Member
There was a problem hiding this comment.
This key should only be a optional parameter.
Author
There was a problem hiding this comment.
Yes, this parameter will be used only after we use the configuration of “agent.namespace” in the java agent. if we don't use it , this parameter can be nil
Member
|
#30 has higher priority, we need it to adopt 8.0 new protocol. |
…InstanceName The Collector use the check for serviceInstanceName startwith "NAME" is upper case。
Member
|
#30 merged, please resolve conflicts and make the CI works. |
Member
|
Any update? |
Member
|
No update in a long time. Have to close for now. |
wu-sheng
added
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the customer parameter for java agent config "agent.namespace", so we can use the traceId from nginx to backend(java) server.