Conversation
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
LGTM. Please test this with 8.0 core backend and java agent. They are ready to test.
|
At apache/skywalking#4599, all java plugin tests are passed. And we are just waiting for @kezhenxu94 updating the e2e test result. |
Sure. |
|
And test results should feedback to mail |
|
@membphis Thanks for your review. |
| local newID = function() | ||
| return timestamp() .. '.' .. math.random(0, MAX_ID_PART2) .. '.' .. math.random(0, MAX_ID_PART3) |
There was a problem hiding this comment.
This function will always run, which is redundant in an OpenResty environment
|
one more thing, is it works with the current version of skywalking? Or we should merge this PR after skywalking 8.0 released? |
It isn't compatible with old SkyWalking release. @mrproliu please add some documentation in this section, https://github.com/apache/skywalking-nginx-lua#download, such as
|
|
yes, we should keep the content of 1.1.0.
Thanks,
Ming Wen
Twitter: _WenMing
mrproliu <notifications@github.com> 于2020年4月7日周二 下午5:44写道：
… ***@***.**** commented on this pull request.
------------------------------
In lib/skywalking/util.lua
<#30 (comment)>
:
>
- return parts
+-- for Nginx Lua
+local ok, uuid = pcall(require, "dependencies/lua-resty-jit-uuid")
We have the file deleted in 2.0.0, lib/skywalking/register.lua.
The skywalking-nginx-lua-1.0-0.rockspec need to keep the content?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBK5A2CY6DNOIIGUHEODRLLYXJANCNFSM4L5RSS2Q>
.
|
| tracingContext = TC.new(serviceName, serviceInstanceName) | ||
|
|
||
| -- Constant pre-defined in SkyWalking main repo | ||
| -- 84 represents Nginx |
There was a problem hiding this comment.
This is a previous wrong comment, please fix this later.
There was a problem hiding this comment.
Send a separated PR for this, I am merging this one.
4 participants
Follow the new v3 protocol, I rewrite the Nginx agent.
Currently, I'm still waiting for the backend to finish, and then I can carry out the E2E test.