Skip to content

Comments

AWS DynamoDB, Lambda, SQS and SNS plugins, webpack#100

Merged
kezhenxu94 merged 10 commits intoapache:masterfrom
tom-pytel:master
Nov 14, 2022
Merged

AWS DynamoDB, Lambda, SQS and SNS plugins, webpack#100
kezhenxu94 merged 10 commits intoapache:masterfrom
tom-pytel:master

Conversation

@tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Nov 12, 2022

The main things here are 4 new AWS SDK2 plugins and webpack support. The full list is:

  • AWS SDK2 DynamoDB plugin.
  • AWS SDK2 Lambda plugin.
  • AWS SDK2 SQS plugin.
  • AWS SDK2 SNS plugin.
  • Instrument deprecated but possibly still used exit calls done(), succeed() and fail() from AWS Lambda function.
  • Allow passing trace ID in AWS Lambda function parameters to allow linking outgoing to incoming calls.
  • Extend AWS flush from boolean always/never to time threshold.
  • Made agent.flush() wait on any unfinished Spans before waiting for protocol send to make sure all Spans in progress finish.
  • Webpack support, can now run with most plugins from a bundle where before agent did not work at all from a bundle.
  • Changed builtin plugin "detection" to explicit specification by plugin.
  • Fix sequential invocation of Lambda function which does not flush and leaves an async component waiting to complete a Span incorrectly linking to a previous sibling Span.
  • Fix double logging and undefined version print if plugin not supported.
  • Fix Axios plugin to not return error but rather empty not supported version string if not supported (is deprecated anyway due to not compatible with Axios v1.0+, need to update).

The AWS plugins are in the plugins/ directory and not the aws/ directory because they are normal Node plugins which can be used on or off AWS to access those AWS services.

@tom-pytel tom-pytel requested a review from kezhenxu94 November 12, 2022 18:11
@tom-pytel tom-pytel added bug Something isn't working enhancement New feature or request plugin labels Nov 12, 2022
@tom-pytel tom-pytel added this to the 0.6.0 milestone Nov 12, 2022
@tom-pytel tom-pytel changed the title AWS DynamoDB, Lambda, SQS and SNS plugins, webpack [WIP] AWS DynamoDB, Lambda, SQS and SNS plugins, webpack Nov 12, 2022
@tom-pytel tom-pytel changed the title [WIP] AWS DynamoDB, Lambda, SQS and SNS plugins, webpack AWS DynamoDB, Lambda, SQS and SNS plugins, webpack Nov 13, 2022
@tom-pytel
Copy link
Contributor Author

Good to go.

@kezhenxu94 kezhenxu94 merged commit e911324 into apache:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants