Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs#9955
Merged
wu-sheng merged 1 commit intoapache:masterfrom Nov 13, 2022
Merged
Nodejs plugin AWSDynamoDB, AWSSNS, AWSSQS component IDs#9955wu-sheng merged 1 commit intoapache:masterfrom
wu-sheng merged 1 commit intoapache:masterfrom
Conversation
wu-sheng
approved these changes
Nov 13, 2022
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
We don't need extra logos for those services, right?
wu-sheng
requested changes
Nov 13, 2022
Comment on lines
428
to
454
| AWSDynamoDB: | ||
| id: 132 | ||
| languages: Java,C#,Node.js,Python | ||
| AWSSNS: | ||
| id: 133 | ||
| languages: Java,C#,Node.js,Python | ||
| AWSSQS: | ||
| id: 134 | ||
| languages: Java,C#,Node.js,Python |
Member
There was a problem hiding this comment.
132-134 have been registered. Please register to new IDs.
Contributor
Author
They would be logos from Amazon itself, I am guessing copyrighted? |
wu-sheng
approved these changes
Nov 13, 2022
Member
|
One more, changes should be uodated. |
Contributor
Author
Yes, will update in a bit. |
Member
|
Merged first, in case of conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: apache/skywalking-nodejs#100
Also includes some previous component server mappings which I guess I forgot to push.