Conversation
Member
|
Thanks. Please add test for the plugin. |
Member
|
@tianyk can you please fix the CI ? |
Member
|
Still, tests failed |
Contributor
Author
|
I've fixed the CI |
Member
Contributor
Author
|
Okay, I've resolved the conflict. |
Member
|
Tests failed because we have #52, can you adjust the expected.data.yaml? |
kezhenxu94
reviewed
May 23, 2021
Member
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
@tianyk thanks, just a minor suggestion, please see my comment
Member
|
Oops, one more thing. Can you update the doc, including mysql2 |
kezhenxu94
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ioredis plugin.