Add mysql2 plugin

[tianyk]

Add mysql2 plugin

[kezhenxu94]

Test failed. Please recheck.

[tianyk]

Please review.

[kezhenxu94]

LGTM, @tom-pytel can you please do another round review?

[zyfyuanyuan6]

@kezhenxu94 @tianyk when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version skywalking-nodejs 0.3.0

[wu-sheng]

@kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0

Isn't this a mysql2 plugin?

[riskgod]

@kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 3.0

Isn't this a mysql2 plugin?

Yep, our team met this err in the same version.

[wu-sheng]

There is no 3.0, I don't know what do you mean?

https://www.npmjs.com/package/mysql2 2.2.5 is the latest release.

[zyfyuanyuan6]

There is no 3.0, I don't know what do you mean?

https://www.npmjs.com/package/mysql2 2.2.5 is the latest release.

sorry i mean skywalking-nodejs 0.3.0 version.

[wu-sheng]

@kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0

Isn't this a mysql2 plugin?

Yep, our team met this err in the same version.

i want to know how can solve it when you meet?

This is open source project, you simply debug directly. I don't know what do you mean.

[riskgod]

version

Still not found the solution, But we can do something in https://github.com/apache/skywalking-nodejs/blob/master/src/core/PluginInstaller.ts#L48

[riskgod]

@kezhenxu94 when i start local server， it will throw an error 'Error installing plugin mysql 2 *', i used version 0.3.0

Isn't this a mysql2 plugin?

Yep, our team met this err in the same version.

i want to know how can solve it when you meet?

This is open source project, you simply debug directly. I don't know what do you mean.

Yep, try to solve it, but the problem is existed, we need try to fix it together.

[kezhenxu94]

@riskgod can you print the error in

skywalking-nodejs/src/core/PluginInstaller.ts

Line 109 in babf6eb

logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`);

in your local env to see what's the error?

[riskgod]

@riskgod can you print the error in

skywalking-nodejs/src/core/PluginInstaller.ts

Line 109 in babf6eb

logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`);

in your local env to see what's the error?

'Error installing plugin mysql 2 *'

[kezhenxu94]

I think you don't understand how to report a potential bug in an open source project and how to help the maintainer to locate it, only providing a error message helps nothing, you don't have a reproducible demo project, nor did you show the Efforts you've made to debug the problem, we are powerless to waste our time to debug this problem as we don't even know whether it's a bug or not because you gave no useful reproducible steps. This plugin is run in our tests with a typical scenario and it passed, if your scenario is different with it you have to provide your scenario in more details, otherwise we are not able to do anything.

We've been asking for more details but you always paste the same error logs, this is a waste of time and useless communication.

@riskgod can you print the error in

skywalking-nodejs/src/core/PluginInstaller.ts

Line 109 in babf6eb

logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`);

in your local env to see what's the error?

'Error installing plugin mysql 2 *'

If you still want to help, try to print the e

skywalking-nodejs/src/core/PluginInstaller.ts

Lines 107 to 113 in babf6eb

	} catch (e) {
	if (plugin) {
	logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`);
	} else {
	logger.error(`Error processing plugin ${pluginFile}`);
	}
	}

Something like this

      } catch (e) {
        if (plugin) {
          logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`, e); // <<===== 👈
        } else {
          logger.error(`Error processing plugin ${pluginFile}`);
        }
      }

... to see why the plugin is not installed successfully.

[riskgod]

I think you don't understand how to report a potential bug in an open source project and how to help the maintainer to locate it, only providing a error message helps nothing, you don't have a reproducible demo project, nor did you show the Efforts you've made to debug the problem, we are powerless to waste our time to debug this problem as we don't even know whether it's a bug or not because you gave no useful reproducible steps. This plugin is run in our tests with a typical scenario and it passed, if your scenario is different with it you have to provide your scenario in more details, otherwise we are not able to do anything.

We've been asking for more details but you always paste the same error logs, this is a waste of time and useless communication.

@riskgod can you print the error in

skywalking-nodejs/src/core/PluginInstaller.ts

Line 109 in babf6eb

logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`);

in your local env to see what's the error?

'Error installing plugin mysql 2 *'

If you still want to help, try to print the e

skywalking-nodejs/src/core/PluginInstaller.ts

Lines 107 to 113 in babf6eb

	} catch (e) {
	if (plugin) {
	logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`);
	} else {
	logger.error(`Error processing plugin ${pluginFile}`);
	}
	}

Something like this

      } catch (e) {
        if (plugin) {
          logger.error(`Error installing plugin ${plugin.module} ${plugin.versions}`, e); // <<===== 👈
        } else {
          logger.error(`Error processing plugin ${pluginFile}`);
        }
      }

... to see why the plugin is not installed successfully.

yep, found the problem. the mysql2 plugin use exports in package.json. not export commonjs in here, like this: ".": "./index.cjs", still try to fix this is in this npm module. Don't worry, I will try to covert that